Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncating passwords to 4096 bytes is useless #1

Closed
JanTvrdik opened this issue Jul 19, 2014 · 2 comments
Closed

Truncating passwords to 4096 bytes is useless #1

JanTvrdik opened this issue Jul 19, 2014 · 2 comments

Comments

@JanTvrdik
Copy link
Contributor

Nette\Security\Passwords truncates password to 4096 bytes. But crypt truncates passwords further to 72 bytes. Is there a reason to not truncate the password in Nette\Security\Passwords directly to 72 bytes or not truncate it all and leave it be for crypt to handle this?

Partially relevant question on SO
@JanTvrdik JanTvrdik changed the title Truncating password to length 4096 is misleading Truncating passwords to 4096 bytes is misleading Jul 19, 2014
@JanTvrdik JanTvrdik changed the title Truncating passwords to 4096 bytes is misleading Truncating passwords to 4096 bytes is useless Jul 19, 2014
@fprochazka
Copy link
Contributor

@JanTvrdik 👍

@dg
Copy link
Member

dg commented Jul 20, 2014

Yes, it is useless.

@dg dg closed this as completed in 9db7e0e Jul 20, 2014
dg added a commit that referenced this issue Aug 24, 2014
@dg
Passwords: removed useless PASSWORD_MAX_LENGTH [Closes #1]
687cd00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fprochazka @JanTvrdik @dg