Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuicCodecBuilder should have a clone() method #150

Closed
thomdev opened this issue Jan 25, 2021 · 0 comments · Fixed by #174
Closed

QuicCodecBuilder should have a clone() method #150

thomdev opened this issue Jan 25, 2021 · 0 comments · Fixed by #174
Milestone
0.0.4.Final

Comments

@thomdev
Copy link
Contributor

thomdev commented Jan 25, 2021

Without cloning, using the same builder and setting properties (e.g channel attributes) from different threads can cause race conditions.
@thomdev thomdev changed the title QUIC codec builders should have a clone() method QuicCodecBuilder should have a clone() method Jan 26, 2021
normanmaurer added a commit that referenced this issue Feb 2, 2021
@normanmaurer
Add clone() method to codec builders
9053090 
Motivation:

It is useful to be able to clone the codec builder.

Modifications:

Add clone method for both codec builders

Result:

Fixes #150
@normanmaurer normanmaurer mentioned this issue Feb 2, 2021
Merged
@normanmaurer normanmaurer added this to the 0.0.4.Final milestone Feb 2, 2021
normanmaurer added a commit that referenced this issue Feb 2, 2021
@normanmaurer
Add clone() method to codec builders
59797be 
Motivation:

It is useful to be able to clone the codec builder.

Modifications:

Add clone method for both codec builders

Result:

Fixes #150
normanmaurer added a commit that referenced this issue Feb 2, 2021
@normanmaurer
Add clone() method to codec builders (#174)
c56bdf9 
Motivation:

It is useful to be able to clone the codec builder.

Modifications:

Add clone method for both codec builders

Result:

Fixes #150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.4.Final
Development

Successfully merging a pull request may close this issue.

Add clone() method to codec builders netty/netty-incubator-codec-quic
2 participants
@normanmaurer @thomdev