Prevent JNI classloader leak #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We should use weak references to hold global references to our own classes as otherwise it will be not possible to unload the classloader. Modifications: Use weak references for the classes in JNI. Result: Related to netty/netty#13480
SgtSilvio
approved these changes
Sep 4, 2023
normanmaurer
added a commit
that referenced
this pull request
Sep 26, 2023
Motivation: The code introduced as part of #574 contained a bug which could crash the JVM. This only manifested in JDK21+ as earlier versions did not contain the related assert. Modifications: Remove left-over call that could crash the JVM Result: Correct code that also works on JDK21
normanmaurer
added a commit
that referenced
this pull request
Sep 26, 2023
Motivation: The code introduced as part of #574 contained a bug which could crash the JVM. This only manifested in JDK21+ as earlier versions did not contain the related assert. Modifications: Remove left-over call that could crash the JVM Result: Correct code that also works on JDK21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We should use weak references to hold global references to our own classes as otherwise it will be not possible to unload the classloader.
Modifications:
Use weak references for the classes in JNI.
Result:
Related to netty/netty#13480