Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance of xml-rs #221

Closed
kornelski opened this issue Aug 12, 2022 · 10 comments
Closed

Maintenance of xml-rs #221

kornelski opened this issue Aug 12, 2022 · 10 comments

Comments

@kornelski
Copy link
Collaborator

I'd like to help with the maintenance of this crate.
@netvl
Copy link
Owner

netvl commented Aug 13, 2022

I will start a process of approval to do anything with this project with my employer. Unfortunately, it will take some time - last time it took about 2.5-3 months. After this is done, I will be able to transfer ownership/add maintainers/etc.

@martin-t martin-t mentioned this issue Aug 15, 2022
Open
10 tasks
@FabianLars FabianLars mentioned this issue Aug 16, 2022
Open
Erk- added a commit to fusion-engineering-forks/rust-mavlink that referenced this issue Aug 18, 2022
@Erk-
use quick-xml instead of xml-rs
4a76af3 
Since XML-rs is for the time being unmaintained[^1], and have been
marked as such in RUSTSET[^2]. I have made ported the XML parsing to
quick-xml.

[^1]: netvl/xml-rs#221

[^2]: https://rustsec.org/advisories/RUSTSEC-2022-0048
@Erk- Erk- mentioned this issue Aug 18, 2022
Merged
Erk- added a commit to fusion-engineering-forks/rust-mavlink that referenced this issue Aug 18, 2022
@Erk-
use quick-xml instead of xml-rs
c87ae26 
Since XML-rs is for the time being unmaintained[^1], and have been
marked as such in RUSTSET[^2]. I have made ported the XML parsing to
quick-xml.

[^1]: netvl/xml-rs#221

[^2]: https://rustsec.org/advisories/RUSTSEC-2022-0048
Erk- added a commit to fusion-engineering-forks/rust-mavlink that referenced this issue Aug 22, 2022
@Erk-
use quick-xml instead of xml-rs
0b6bd51 
Since XML-rs is for the time being unmaintained[^1], and have been
marked as such in RUSTSET[^2]. I have made ported the XML parsing to
quick-xml.

[^1]: netvl/xml-rs#221

[^2]: https://rustsec.org/advisories/RUSTSEC-2022-0048
patrickelectric pushed a commit to mavlink/rust-mavlink that referenced this issue Aug 22, 2022
@Erk- @patrickelectric
use quick-xml instead of xml-rs
3ea2434 
Since XML-rs is for the time being unmaintained[^1], and have been
marked as such in RUSTSET[^2]. I have made ported the XML parsing to
quick-xml.

[^1]: netvl/xml-rs#221

[^2]: https://rustsec.org/advisories/RUSTSEC-2022-0048
@ilslv ilslv mentioned this issue Sep 9, 2022
Merged
@untereiner
Copy link

untereiner commented Oct 4, 2022 •
edited
Loading

Hi @netvl ! Any news on this ?

@ozgunozerk ozgunozerk mentioned this issue Oct 6, 2022
Closed
@ozgunozerk ozgunozerk mentioned this issue Oct 17, 2022
Open
2 tasks
@mgeisler
Copy link

mgeisler commented Nov 8, 2022

Hi @netvl, I would also like to help here, if needed. I work on Android as part of the team which supports Rust in Android. We use the crate in an Android component related to virtualization. So we'll like to help with the maintenance 😃

@netvl
Copy link
Owner

netvl commented Nov 16, 2022

Hi @kornelski @untereiner @mgeisler
I really appreciate your suggestions to take over maintenance of this crate!
I’m sorry for the radio silence - I can only say that I did request an approval for project transfer some time ago, but unfortunately I can’t tell how long it would take to be fully processed. From my experience, this timing is inconsistent, and may be further delayed by holidays. I will update this ticket immediately once I get the approval.

@netvl netvl mentioned this issue Nov 16, 2022
Closed
@netvl
Copy link
Owner

netvl commented Dec 23, 2022

Hi everyone,

I have good news - I have just received an approval to go through with the maintenance transfer. I can do the necessary work any time. That being said, I'm not sure who I can transfer the crate to. Those who volunteered, is it all right for me to ask you to confirm your intention here? I personally don't really have a specific preference, but if you have experience with crate maintenance/have some crates that you actively maintain, that would be the best. Thank you!

@hoijui
Copy link

hoijui commented Dec 23, 2022

niiiice! :-)
I would prefer not to be in charge. I would vote for one person being in charge, but one or two more to also have owner rights (also: probably not me). I would do the later, in case something simple needs be done quick, and the main person is on holidays or goes missing due to personal issues in life.

@kornelski
Copy link
Collaborator Author

I'm still interested.

@Berrysoft Berrysoft mentioned this issue Jan 4, 2023
Closed
@dfyz dfyz mentioned this issue Jan 23, 2023
Merged
dfyz added a commit to dfyz/osm-renderer that referenced this issue Jan 23, 2023
@dfyz
[audit] xml-rs → quick-xml (#10)
ef94af4 
`xml-rs` [is not maintained](https://rustsec.org/advisories/RUSTSEC-2022-0048) anymore. It is apparently [currently being](netvl/xml-rs#221 (comment)) transferred, but even if that happens (which is not a given), `xml-rs` still appears to have a large backlog of unresolved issues. Looks like it's time to switch.

I found two crates that are actively maintained and can do SAX parsing:
  * [quick-xml](https://github.com/tafia/quick-xml). Clean codebase, no `unsafe`, lots of tests, lots of recent commits. Lots of dependencies as well, but fortunately all of them are optional except `memchr`, which I guess is OK. The API is similar to `xml-rs`, so migration is mostly straightforward.
  * [xmlparser](https://github.com/RazrFalcon/xmlparser). An absolute gem of a library: no dependencies at all, small and clean codebase, no `unsafe`. Unfortunately, the API doesn't group attributes together (the current geodata importer [relies](https://github.com/dfyz/osm-renderer/blob/87266a44464447be4951d4c244a7f85bc054e59c/src/geodata/importer.rs#L372) on that), and I don't want to make too invasive changes when switching.

So, `quick-xml` it is (for now). By the way, it really lives up to its name: importing Serbia now takes **01:08** minutes on my laptop, while it used to take **02:51** minutes.
@Nilirad Nilirad mentioned this issue Mar 7, 2023
Merged
jrhawley added a commit to jrhawley/hb that referenced this issue Apr 19, 2023
@jrhawley
Ignoring certain Rust security vulnerabilities
9314e35 
[Here](netvl/xml-rs#221) is the issues about xml-rs's maintenance.
@kornelski
Copy link
Collaborator Author

I'm the new maintainer now. The new repo is at https://github.com/kornelski/xml-rs

@netvl
Copy link
Owner

netvl commented May 8, 2023

Big thanks for @kornelski to taking over the maintenance!
@kornelski have you switched everything to the new repo? Do you think it would make sense to archive this one? I wanted to suggest to transfer the repository to keep the issue/PR history as well, but if you think that it is unnecessary it is also fine, I guess)

@kornelski
Copy link
Collaborator Author

It would be nice if you could transfer the repo, or at least give me access so that I can close issues.

@nightkr nightkr mentioned this issue Jun 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@hoijui @kornelski @mgeisler @netvl @untereiner