-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for cmd-repos have deps on sdk-vppagent, sdk-k8s, sdk-sriov #15
Merged
haiodo
merged 1 commit into
networkservicemesh:master
from
denis-tingaikin:update_ci_yaml
Sep 7, 2020
Merged
Allow for cmd-repos have deps on sdk-vppagent, sdk-k8s, sdk-sriov #15
haiodo
merged 1 commit into
networkservicemesh:master
from
denis-tingaikin:update_ci_yaml
Sep 7, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: denis-tingajkin <[email protected]>
denis-tingaikin
force-pushed
the
update_ci_yaml
branch
from
September 7, 2020 07:19
98a4483
to
209446b
Compare
haiodo
approved these changes
Sep 7, 2020
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc
that referenced
this pull request
Sep 7, 2020
…template@master networkservicemesh/cmd-template#15 networkservicemesh/cmd-template PR link: networkservicemesh/cmd-template#15 networkservicemesh/cmd-template commit message: commit f44fe58e4206ec0bc8138a988ff7b59100e0a3ca Author: Denis Tingaikin <[email protected]> Date: Mon Sep 7 14:22:01 2020 +0700 Allow for cmd-repos have deps on sdk-vppagent, sdk-k8s, sdk-sriov (#15) Signed-off-by: denis-tingajkin <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vppagent
that referenced
this pull request
Sep 7, 2020
…template@master networkservicemesh/cmd-template#15 networkservicemesh/cmd-template PR link: networkservicemesh/cmd-template#15 networkservicemesh/cmd-template commit message: commit f44fe58e4206ec0bc8138a988ff7b59100e0a3ca Author: Denis Tingaikin <[email protected]> Date: Mon Sep 7 14:22:01 2020 +0700 Allow for cmd-repos have deps on sdk-vppagent, sdk-k8s, sdk-sriov (#15) Signed-off-by: denis-tingajkin <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Sep 7, 2020
…template@master networkservicemesh/cmd-template#15 networkservicemesh/cmd-template PR link: networkservicemesh/cmd-template#15 networkservicemesh/cmd-template commit message: commit f44fe58e4206ec0bc8138a988ff7b59100e0a3ca Author: Denis Tingaikin <[email protected]> Date: Mon Sep 7 14:22:01 2020 +0700 Allow for cmd-repos have deps on sdk-vppagent, sdk-k8s, sdk-sriov (#15) Signed-off-by: denis-tingajkin <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Sep 7, 2020
…template@master networkservicemesh/cmd-template#15 networkservicemesh/cmd-template PR link: networkservicemesh/cmd-template#15 networkservicemesh/cmd-template commit message: commit f44fe58e4206ec0bc8138a988ff7b59100e0a3ca Author: Denis Tingaikin <[email protected]> Date: Mon Sep 7 14:22:01 2020 +0700 Allow for cmd-repos have deps on sdk-vppagent, sdk-k8s, sdk-sriov (#15) Signed-off-by: denis-tingajkin <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Sep 7, 2020
…template@master networkservicemesh/cmd-template#15 networkservicemesh/cmd-template PR link: networkservicemesh/cmd-template#15 networkservicemesh/cmd-template commit message: commit f44fe58e4206ec0bc8138a988ff7b59100e0a3ca Author: Denis Tingaikin <[email protected]> Date: Mon Sep 7 14:22:01 2020 +0700 Allow for cmd-repos have deps on sdk-vppagent, sdk-k8s, sdk-sriov (#15) Signed-off-by: denis-tingajkin <[email protected]> Signed-off-by: NSMBot <[email protected]>
xzfc
reviewed
Sep 7, 2020
@@ -89,7 +89,7 @@ jobs: | |||
- name: Restrict dependencies on github.com/networkservicemesh/* | |||
run: | | |||
for i in $(grep github.com/networkservicemesh/ go.mod |grep -v '^module' | sed 's;.*\(github.com\/networkservicemesh\/[a-zA-z\/]*\).*;\1;g' | sort -u);do | |||
if [ "${i}" != "github.com/networkservicemesh/sdk" ] && [ "${i}" != "github.com/networkservicemesh/api" ]; then | |||
if [ "${i}" != "github.com/networkservicemesh/sdk-vppagent" ] && [ "${i}" != "github.com/networkservicemesh/sdk" ] && [ "${i}" != "github.com/networkservicemesh/api" ] && [ "${i}" != "github.com/networkservicemesh/sdk-k8s" && [ "${i}" != "github.com/networkservicemesh/sdk-sriov" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the last one ]
is misplaced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: denis-tingajkin [email protected]