fix: cmd-* app should be able to delete a branch in case of its own update #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: denis-tingajkin <[email protected]>
denis-tingaikin
commented
Nov 9, 2020
| @@ -261,6 +261,12 @@ jobs: | |||
| sdkPattern="github.com\/networkservicemesh\/sdk " | |||
| sdkVersion=$(grep --regexp "${sdkPattern}" go.mod) | |||
| branchName="${sdkVersion:${#sdkPattern}}" | |||
| else | |||
There was a problem hiding this comment.
Note: this case if the update is not passed from sdk
haiodo
approved these changes
Nov 9, 2020
nsmbot
pushed a commit
to networkservicemesh/cmd-exclude-prefixes-k8s
that referenced
this pull request
Nov 9, 2020
…template@master networkservicemesh/cmd-template#37 networkservicemesh/cmd-template PR link: networkservicemesh/cmd-template#37 networkservicemesh/cmd-template commit message: commit 598fbc2f78ae997654c0a07aa5baea677809f8ce Author: Denis Tingaikin <[email protected]> Date: Mon Nov 9 23:34:41 2020 +0700 fix error: "too many arguments" (#37) Signed-off-by: denis-tingajkin <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Nov 9, 2020
…template@master networkservicemesh/cmd-template#37 networkservicemesh/cmd-template PR link: networkservicemesh/cmd-template#37 networkservicemesh/cmd-template commit message: commit 598fbc2f78ae997654c0a07aa5baea677809f8ce Author: Denis Tingaikin <[email protected]> Date: Mon Nov 9 23:34:41 2020 +0700 fix error: "too many arguments" (#37) Signed-off-by: denis-tingajkin <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Nov 9, 2020
…template@master networkservicemesh/cmd-template#37 networkservicemesh/cmd-template PR link: networkservicemesh/cmd-template#37 networkservicemesh/cmd-template commit message: commit 598fbc2f78ae997654c0a07aa5baea677809f8ce Author: Denis Tingaikin <[email protected]> Date: Mon Nov 9 23:34:41 2020 +0700 fix error: "too many arguments" (#37) Signed-off-by: denis-tingajkin <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-sriov
that referenced
this pull request
Nov 9, 2020
…template@master networkservicemesh/cmd-template#37 networkservicemesh/cmd-template PR link: networkservicemesh/cmd-template#37 networkservicemesh/cmd-template commit message: commit 598fbc2f78ae997654c0a07aa5baea677809f8ce Author: Denis Tingaikin <[email protected]> Date: Mon Nov 9 23:34:41 2020 +0700 fix error: "too many arguments" (#37) Signed-off-by: denis-tingajkin <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Nov 9, 2020
…template@master networkservicemesh/cmd-template#37 networkservicemesh/cmd-template PR link: networkservicemesh/cmd-template#37 networkservicemesh/cmd-template commit message: commit 598fbc2f78ae997654c0a07aa5baea677809f8ce Author: Denis Tingaikin <[email protected]> Date: Mon Nov 9 23:34:41 2020 +0700 fix error: "too many arguments" (#37) Signed-off-by: denis-tingajkin <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vppagent
that referenced
this pull request
Nov 9, 2020
…template@master networkservicemesh/cmd-template#37 networkservicemesh/cmd-template PR link: networkservicemesh/cmd-template#37 networkservicemesh/cmd-template commit message: commit 598fbc2f78ae997654c0a07aa5baea677809f8ce Author: Denis Tingaikin <[email protected]> Date: Mon Nov 9 23:34:41 2020 +0700 fix error: "too many arguments" (#37) Signed-off-by: denis-tingajkin <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Nov 9, 2020
…template@master networkservicemesh/cmd-template#37 networkservicemesh/cmd-template PR link: networkservicemesh/cmd-template#37 networkservicemesh/cmd-template commit message: commit 598fbc2f78ae997654c0a07aa5baea677809f8ce Author: Denis Tingaikin <[email protected]> Date: Mon Nov 9 23:34:41 2020 +0700 fix error: "too many arguments" (#37) Signed-off-by: denis-tingajkin <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc
that referenced
this pull request
Nov 9, 2020
…template@master networkservicemesh/cmd-template#37 networkservicemesh/cmd-template PR link: networkservicemesh/cmd-template#37 networkservicemesh/cmd-template commit message: commit 598fbc2f78ae997654c0a07aa5baea677809f8ce Author: Denis Tingaikin <[email protected]> Date: Mon Nov 9 23:34:41 2020 +0700 fix error: "too many arguments" (#37) Signed-off-by: denis-tingajkin <[email protected]> Signed-off-by: NSMBot <[email protected]>
This was referenced Nov 9, 2020
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: denis-tingajkin [email protected]