Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healing #31

Merged
merged 11 commits into from
Dec 14, 2020
Merged

Healing #31

merged 11 commits into from
Dec 14, 2020

Conversation

Bolodya1997
Copy link

@Bolodya1997 Bolodya1997 commented Oct 28, 2020

Issues

  1. If forwarder restarts we loose already allocated SR-IOV token IDs.
  2. If vfio-pci driver is bounded to the kernel interface by default, we can't get kernel driver automatically.
  3. User needs to manually fetch all PCI functions and then pass it to the resource pool, it looks awful in code.
  4. In VFIO case VF has no kernel interface, so we shouldn't fetch it.
  5. If device access permissions are given only to the container that makes the request, we miss the case when it is a sidecar container and client container still lacks permissions.

Solutions

  1. Add token.Pool Refresh to allow device plugin update allocated IDs on start.
  2. Add pfKernelDriver, vfKernelDriver to sriovconfig.Config.
  3. Add pci.Pool, pci.UpdateConfig to centralize PCI functions processing.
  4. Don't fetch kernel interface name for the VFIO case.
  5. Use regex for giving permissions for all containers in pod.

Vladimir Popov added 5 commits December 9, 2020 17:44
Signed-off-by: Vladimir Popov <[email protected]>
Signed-off-by: Vladimir Popov <[email protected]>
Signed-off-by: Vladimir Popov <[email protected]>
Signed-off-by: Vladimir Popov <[email protected]>
Vladimir Popov added 5 commits December 9, 2020 21:04
Signed-off-by: Vladimir Popov <[email protected]>
Signed-off-by: Vladimir Popov <[email protected]>
Signed-off-by: Vladimir Popov <[email protected]>
@Bolodya1997 Bolodya1997 marked this pull request as ready for review December 9, 2020 14:11
@Bolodya1997 Bolodya1997 marked this pull request as draft December 10, 2020 02:06
Signed-off-by: Vladimir Popov <[email protected]>
@haiodo haiodo merged commit af9f4fd into networkservicemesh:master Dec 14, 2020
nsmbot pushed a commit to networkservicemesh/cmd-nsc that referenced this pull request Dec 14, 2020
…k-sriov@master networkservicemesh/sdk-sriov#31

networkservicemesh/sdk-sriov PR link: networkservicemesh/sdk-sriov#31

networkservicemesh/sdk-sriov commit message:
commit af9f4fd3f0998f726be5009d1aab1a86c87993c4
Author: Andrey Sobolev <[email protected]>
Date:   Mon Dec 14 18:55:06 2020 +0700

    Merge pull request #31 from Bolodya1997/healing

    Healing

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-sriov that referenced this pull request Dec 14, 2020
…k-sriov@master networkservicemesh/sdk-sriov#31

networkservicemesh/sdk-sriov PR link: networkservicemesh/sdk-sriov#31

networkservicemesh/sdk-sriov commit message:
commit af9f4fd3f0998f726be5009d1aab1a86c87993c4
Author: Andrey Sobolev <[email protected]>
Date:   Mon Dec 14 18:55:06 2020 +0700

    Merge pull request #31 from Bolodya1997/healing

    Healing

Signed-off-by: NSMBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants