Make vxlan port configurable #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zolug
added a commit
to Nordix/nsm-cmd-forwarder-vpp
that referenced
this pull request
Sep 29, 2021
networkservicemesh/sdk-vpp commit message: Make vxlan port configurable (see networkservicemesh/sdk-vpp#394) networkservicemesh/sdk commit message: Make vxlan port configurable (see networkservicemesh/sdk#1091) Signed-off-by: Zoltan Lugossy <[email protected]>
zolug
added a commit
to Nordix/nsm-cmd-forwarder-vpp
that referenced
this pull request
Sep 29, 2021
networkservicemesh/sdk-vpp commit message: Make vxlan port configurable (see networkservicemesh/sdk-vpp#394) networkservicemesh/sdk commit message: Make vxlan port configurable (see networkservicemesh/sdk#1091) Signed-off-by: Zoltan Lugossy <[email protected]>
|
I believe if you rebase this on main you will find it passes CI :) |
zolug
added a commit
to Nordix/nsm-cmd-forwarder-vpp
that referenced
this pull request
Sep 30, 2021
networkservicemesh/sdk-vpp commit message: Make vxlan port configurable (see networkservicemesh/sdk-vpp#394) networkservicemesh/sdk commit message: Make vxlan port configurable (see networkservicemesh/sdk#1091) Signed-off-by: Zoltan Lugossy <[email protected]>
edwarnicke
reviewed
Sep 30, 2021
| @@ -42,9 +42,9 @@ type vxlanServer struct { | |||
| } | |||
|
|
|||
| // NewServer - returns a new server for the vxlan remote mechanism | |||
| func NewServer(vppConn api.Connection, tunnelIP net.IP) networkservice.NetworkServiceServer { | |||
| func NewServer(vppConn api.Connection, tunnelIP net.IP, vniOptions ...vni.Option) networkservice.NetworkServiceServer { | |||
There was a problem hiding this comment.
Could we please make the Option pattern here local to this package... importing another packages option here precludes other unrelated Options in the future.
edwarnicke
reviewed
Sep 30, 2021
| type Option func(o *vxlanOpions) | ||
|
|
||
| // WithVniOptions sets vni options | ||
| func WithVniOptions(vniOptions ...vni.Option) Option { |
There was a problem hiding this comment.
Could we please make this a WithVniPort that takes an int. Passing layers of Options cross binds us at the API level in an unpleasant way. Its easy enough to translate the options in the NewClient/NewServer functions.
edwarnicke
reviewed
Sep 30, 2021
| } | ||
| } | ||
|
|
||
| type vxlanOpions struct { |
There was a problem hiding this comment.
typo:
Suggested change
| type vxlanOpions struct { | |
| type vxlanOptions struct { |
edwarnicke
reviewed
Sep 30, 2021
| } | ||
|
|
||
| type vxlanOpions struct { | ||
| vniPort uint16 |
There was a problem hiding this comment.
Suggested change
| vniPort uint16 | |
| port uint16 |
edwarnicke
reviewed
Sep 30, 2021
| @@ -44,13 +44,18 @@ type vxlanClient struct { | |||
| } | |||
|
|
|||
| // NewClient - returns a new client for the vxlan remote mechanism | |||
| func NewClient(vppConn api.Connection, tunnelIP net.IP) networkservice.NetworkServiceClient { | |||
| func NewClient(vppConn api.Connection, tunnelIP net.IP, options ...Option) networkservice.NetworkServiceClient { | |||
| opts := &vxlanOpions{} | |||
There was a problem hiding this comment.
Suggested change
| opts := &vxlanOpions{} | |
| opts := &vxlanOptions{ | |
| port: 4789, | |
| } |
networkservicemesh/sdk commit message: Make vxlan port configurable (see networkservicemesh/sdk#1091) Signed-off-by: Zoltan Lugossy <[email protected]>
denis-tingaikin
approved these changes
Oct 6, 2021
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Oct 6, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#394 Commit: a3f3e2c Author: zolug Date: 2021-10-06 22:52:48 +0200 Message: - Make vxlan port configurable (#394) networkservicemesh/sdk commit message: Make vxlan port configurable (see networkservicemesh/sdk#1091) Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Oct 6, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#394 Commit: a3f3e2c Author: zolug Date: 2021-10-06 22:52:48 +0200 Message: - Make vxlan port configurable (#394) networkservicemesh/sdk commit message: Make vxlan port configurable (see networkservicemesh/sdk#1091) Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Oct 6, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#394 Commit: a3f3e2c Author: zolug Date: 2021-10-06 22:52:48 +0200 Message: - Make vxlan port configurable (#394) networkservicemesh/sdk commit message: Make vxlan port configurable (see networkservicemesh/sdk#1091) Signed-off-by: NSMBot <[email protected]>
This was referenced Oct 6, 2021
Merged
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Oct 6, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#394 Commit: a3f3e2c Author: zolug Date: 2021-10-06 22:52:48 +0200 Message: - Make vxlan port configurable (#394) networkservicemesh/sdk commit message: Make vxlan port configurable (see networkservicemesh/sdk#1091) Signed-off-by: NSMBot <[email protected]>
zolug
added a commit
to Nordix/nsm-cmd-forwarder-vpp
that referenced
this pull request
Oct 7, 2021
networkservicemesh/sdk-vpp commit message: Make vxlan port configurable (see networkservicemesh/sdk-vpp#394) networkservicemesh/sdk commit message: Make vxlan port configurable (see networkservicemesh/sdk#1091) Signed-off-by: Zoltan Lugossy <[email protected]>
zolug
added a commit
to Nordix/nsm-cmd-forwarder-vpp
that referenced
this pull request
Oct 7, 2021
networkservicemesh/sdk-vpp commit message: Make vxlan port configurable (see networkservicemesh/sdk-vpp#394) networkservicemesh/sdk commit message: Make vxlan port configurable (see networkservicemesh/sdk#1091) Signed-off-by: Zoltan Lugossy <[email protected]>
edwarnicke
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Oct 7, 2021
networkservicemesh/sdk-vpp commit message: Make vxlan port configurable (see networkservicemesh/sdk-vpp#394) networkservicemesh/sdk commit message: Make vxlan port configurable (see networkservicemesh/sdk#1091) Signed-off-by: Zoltan Lugossy <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Oct 7, 2021
…d-forwarder-vpp@main PR link: https://github.com/networkservicemesh/cmd-forwarder-vpp/pull/ Commit: d531e5d Author: zolug Date: 2021-10-07 16:23:45 +0200 Message: - Make vxlan port configurable (#341) (#352) networkservicemesh/sdk-vpp commit message: Make vxlan port configurable (see networkservicemesh/sdk-vpp#394) networkservicemesh/sdk commit message: Make vxlan port configurable (see networkservicemesh/sdk#1091) Signed-off-by: NSMBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
networkservicemesh/sdk commit message:
Make vxlan port configurable
Signed-off-by: Zoltan Lugossy [email protected]