Add options to the forwarder to use it with an external vpp #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glazychev-art
force-pushed
the
forwarder_opts
branch
from
7d9604f
to
1de021c
Compare
glazychev-art
changed the title
Signed-off-by: Artem Glazychev <[email protected]>
glazychev-art
force-pushed
the
forwarder_opts
branch
from
1de021c
to
6da782a
Compare
| func NewServer(ctx context.Context, name string, authzServer networkservice.NetworkServiceServer, tokenGenerator token.GeneratorFunc, clientURL *url.URL, vppConn Connection, tunnelIP net.IP, tunnelPort uint16, dialTimeout time.Duration, domain2Device map[string]string, clientDialOptions ...grpc.DialOption) endpoint.Endpoint { | ||
| nseClient := registryclient.NewNetworkServiceEndpointRegistryClient(ctx, clientURL, | ||
| func NewServer(ctx context.Context, tokenGenerator token.GeneratorFunc, vppConn Connection, tunnelIP net.IP, options ...Option) endpoint.Endpoint { | ||
| opts := &forwarderOptions{ |
There was a problem hiding this comment.
Missed default parameters for:
authorizeServer -> null server
clientURL -> default connectTo
dialTimeout -> 200ms
domain2Device ->empty map
There was a problem hiding this comment.
I thought it was the responsibility of each individual chain element. Forwarder just passes options. Otherwise, it will turn out that at each iteration we will set new default parameters:
func AnyOtherNewServer(opts ...Options) {
/* set default parameters */
...
forwarder.NewServer(..., forwarder.WithOption(opts.AnyOption)) <- new default parameters inside forwarder.NewServer
...
}
Name is set, because we want to keep consistency inside the forwarder (used in the client and endpoint chain).
And, do we have a constant for dialTimeout or clientURL?
@denis-tingaikin Any thoughts?
There was a problem hiding this comment.
@glazychev-art option means that the value is not required. I don't think that clientURL== nil and dialTimeout == 0 are good values by default. Also I'm fine to make these values as required.
Signed-off-by: Artem Glazychev <[email protected]>
denis-tingaikin
approved these changes
Mar 18, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Mar 18, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#530 Commit: 9984c7c Author: Artem Glazychev Date: 2022-03-18 15:04:18 +0700 Message: - Add options to the forwarder to use it with an external vpp (#530) * Add options to the forwarder to use it with an external vpp Signed-off-by: Artem Glazychev <[email protected]> * Add default values Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Mar 18, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#530 Commit: 9984c7c Author: Artem Glazychev Date: 2022-03-18 15:04:18 +0700 Message: - Add options to the forwarder to use it with an external vpp (#530) * Add options to the forwarder to use it with an external vpp Signed-off-by: Artem Glazychev <[email protected]> * Add default values Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Mar 18, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#530 Commit: 9984c7c Author: Artem Glazychev Date: 2022-03-18 15:04:18 +0700 Message: - Add options to the forwarder to use it with an external vpp (#530) * Add options to the forwarder to use it with an external vpp Signed-off-by: Artem Glazychev <[email protected]> * Add default values Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Mar 18, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#530 Commit: 9984c7c Author: Artem Glazychev Date: 2022-03-18 15:04:18 +0700 Message: - Add options to the forwarder to use it with an external vpp (#530) * Add options to the forwarder to use it with an external vpp Signed-off-by: Artem Glazychev <[email protected]> * Add default values Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vlan-vpp
that referenced
this pull request
Mar 18, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#530 Commit: 9984c7c Author: Artem Glazychev Date: 2022-03-18 15:04:18 +0700 Message: - Add options to the forwarder to use it with an external vpp (#530) * Add options to the forwarder to use it with an external vpp Signed-off-by: Artem Glazychev <[email protected]> * Add default values Signed-off-by: NSMBot <[email protected]>
This was referenced Mar 18, 2022
Merged
edwarnicke
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Mar 20, 2022
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main PR link: networkservicemesh/sdk-vpp#530 Commit: 9984c7c Author: Artem Glazychev Date: 2022-03-18 15:04:18 +0700 Message: - Add options to the forwarder to use it with an external vpp (#530) * Add options to the forwarder to use it with an external vpp Signed-off-by: Artem Glazychev <[email protected]> * Add default values Signed-off-by: NSMBot <[email protected]> * Update forwarder to use it with an external vpp Signed-off-by: Artem Glazychev <[email protected]> * Use vpp instead of vpp-ext Signed-off-by: Artem Glazychev <[email protected]> Co-authored-by: NSMBot <[email protected]> Co-authored-by: Network Service Mesh Bot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Mar 20, 2022
…d-forwarder-vpp@main PR link: networkservicemesh/cmd-forwarder-vpp#530 Commit: f80658e Author: Artem Glazychev Date: 2022-03-21 04:39:18 +0700 Message: - Update forwarder to use it with an external vpp (#530) * Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main PR link: networkservicemesh/sdk-vpp#530 Commit: 9984c7c Author: Artem Glazychev Date: 2022-03-18 15:04:18 +0700 Message: - Add options to the forwarder to use it with an external vpp (#530) * Add options to the forwarder to use it with an external vpp Signed-off-by: Artem Glazychev <[email protected]> * Add default values Signed-off-by: NSMBot <[email protected]> * Update forwarder to use it with an external vpp Signed-off-by: Artem Glazychev <[email protected]> * Use vpp instead of vpp-ext Signed-off-by: Artem Glazychev <[email protected]> Co-authored-by: NSMBot <[email protected]> Signed-off-by: NSMBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: networkservicemesh/integration-k8s-kind#325
Signed-off-by: Artem Glazychev [email protected]