Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that NSM candidate selection is working as fast as possible #1438

Closed
3 tasks
denis-tingaikin opened this issue Mar 21, 2023 · 2 comments
Closed
3 tasks
Assignees
Labels
bug Something isn't working

Comments

@denis-tingaikin
Copy link
Member

denis-tingaikin commented Mar 21, 2023

Overview

Seems like permutation mechanics doesn't work well. See at networkservicemesh/cmd-registry-k8s#376

This could be super useful for folks who want to use their custom registry service or some buggy registry service.

By this reason we need to test and fix our nse iteration logic in the discover and roundrobin chain elements and test it on the real clusteres

Test scenario

  1. Deploy NSM
  2. Deploy 100 nses
  3. Deploy 1 nsc
  4. Make nses from step 2 unreachable
  5. Deploy a new reachable nse

Expected: nsc should reach the nse
Actual: ?

TODO list

  • add unit tests
  • fix issues if they exist
  • check the scenario on the packet cluster
@NikitaSkrynnik
Copy link
Contributor

Tested basic NSM setup with 10, 20, 40 dead NSEs and 1 working NSE on Azure Cluster. Also tested 40 dead forwarders to check discover in NSMGR. Both discovers in nsmgr and forwarder work fast. Connection is established on the first attepmt.

Here are the logs for each experiment:

  1. 10 dead NSEs and 1 working NSE - 10nse.zip
  2. 20 dead NSEs and 1 working NSE - 20nse.zip
  3. 40 dead NSEs and 1 working NSE - 40nse.zip
  4. 40 dead FWDs and 1 workfing NSE - 40fwds.zip
  5. 40 dead and deleted NSEs and 1 working NSE - 40nses-deleted.zip

@denis-tingaikin
Copy link
Member Author

Closing by #1438 (comment)

@github-project-automation github-project-automation bot moved this from Moved to next release to Done in Release v1.9.0 Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Status: Done
Development

No branches or pull requests

2 participants