[deployments-k8s#2003] Add discover close for expired NSE #1013
Conversation
| } | ||
|
|
||
| return next.Server(ctx).Close(clienturlctx.WithClientURL(ctx, u), conn) |
There was a problem hiding this comment.
Am I get it correctly that in case if endpoint is unreachable we will call next with expired ctx?
There was a problem hiding this comment.
We have ctx.Deadline() / 10 timeout for discoverNetworkServiceEndpoint, so it wouldn't be expired.
Bolodya1997
force-pushed
the
deployments-k8s#2003/discover-close
branch
from
7835ba9
to
8abe6be
Compare
Bolodya1997
force-pushed
the
deployments-k8s#2003/discover-close
branch
from
7d72de1
to
c0176e8
Compare
Bolodya1997
changed the title
| @@ -1,4 +1,4 @@ | |||
| // Copyright (c) 2020 Cisco Systems, Inc. | |||
| // Copyright (c) 2020-2021 Cisco Systems, Inc. | |||
There was a problem hiding this comment.
| // Copyright (c) 2020-2021 Cisco Systems, Inc. | |
| // Copyright (c) 2020 Cisco Systems, Inc. | |
| // | |
| // Copyright (c) 2021 Doc.ai and/or its affiliates. |
| touchServer.touched = false | ||
|
|
||
| _, err = client.Close(context.TODO(), conn) | ||
| _, err = client.Request(context.TODO(), request) |
There was a problem hiding this comment.
Can we change TODO context?
There was a problem hiding this comment.
Removed commit modifying interpose, guess it is no more part of the PR.
| var crossCTX context.Context | ||
| if conn.GetId() == connInfo.clientConnID { | ||
| crossCTX = clienturlctx.WithClientURL(ctx, connInfo.interposeNSEURL) |
There was a problem hiding this comment.
Why we don't need more to pass clienturl to interposeNSE?
There was a problem hiding this comment.
Removed commit modifying interpose, guess it is no more part of the PR.
| } | ||
| return next.Server(ctx).Close(clienturlctx.WithClientURL(ctx, u), conn) | ||
|
|
||
| // Connect server already has a client URL for the conn.Id, so we don't need to set it here. |
There was a problem hiding this comment.
I don't think that discover server should know about connect server.
Bolodya1997
force-pushed
the
deployments-k8s#2003/discover-close
branch
from
f5c8bc7
to
d42b11c
Compare
Bolodya1997
changed the title
Signed-off-by: Vladimir Popov <[email protected]>
Bolodya1997
force-pushed
the
deployments-k8s#2003/discover-close
branch
from
d42b11c
to
34f33d7
Compare
Description
Adds
Closepropagation fordiscoverfor not existing (probably expired) NSE case.Issue link
networkservicemesh/deployments-k8s#2003
How Has This Been Tested?
Types of changes