[qfix] Manually cleanup old mechanism on Close in mechanismtranslation
#1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Popov <[email protected]>
Bolodya1997
requested review from
denis-tingaikin,
glazychev-art and
Mixaster995
Mixaster995
approved these changes
Oct 12, 2021
glazychev-art
approved these changes
Oct 12, 2021
denis-tingaikin
approved these changes
Oct 12, 2021
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Oct 12, 2021
…k@main PR link: networkservicemesh/sdk#1100 Commit: 96a8103 Author: Vladimir Popov Date: 2021-10-12 13:44:13 +0700 Message: - Manually cleanup old mechanism on Close in mechanismtranslation (#1100) Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Oct 12, 2021
…k@main PR link: networkservicemesh/sdk#1100 Commit: 96a8103 Author: Vladimir Popov Date: 2021-10-12 13:44:13 +0700 Message: - Manually cleanup old mechanism on Close in mechanismtranslation (#1100) Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Oct 12, 2021
…k@main PR link: networkservicemesh/sdk#1100 Commit: 96a8103 Author: Vladimir Popov Date: 2021-10-12 13:44:13 +0700 Message: - Manually cleanup old mechanism on Close in mechanismtranslation (#1100) Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Oct 12, 2021
…k@main PR link: networkservicemesh/sdk#1100 Commit: 96a8103 Author: Vladimir Popov Date: 2021-10-12 13:44:13 +0700 Message: - Manually cleanup old mechanism on Close in mechanismtranslation (#1100) Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Oct 12, 2021
…k@main PR link: networkservicemesh/sdk#1100 Commit: 96a8103 Author: Vladimir Popov Date: 2021-10-12 13:44:13 +0700 Message: - Manually cleanup old mechanism on Close in mechanismtranslation (#1100) Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Oct 12, 2021
…k@main PR link: networkservicemesh/sdk#1100 Commit: 96a8103 Author: Vladimir Popov Date: 2021-10-12 13:44:13 +0700 Message: - Manually cleanup old mechanism on Close in mechanismtranslation (#1100) Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Oct 12, 2021
…k@main PR link: networkservicemesh/sdk#1100 Commit: 96a8103 Author: Vladimir Popov Date: 2021-10-12 13:44:13 +0700 Message: - Manually cleanup old mechanism on Close in mechanismtranslation (#1100) Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Oct 12, 2021
…k@main PR link: networkservicemesh/sdk#1100 Commit: 96a8103 Author: Vladimir Popov Date: 2021-10-12 13:44:13 +0700 Message: - Manually cleanup old mechanism on Close in mechanismtranslation (#1100) Signed-off-by: NSMBot <[email protected]>
This was referenced Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manually cleans up old mechanism on Close in
mechanismtranslation.Motivation
If Close happens in the middle of the chain,
metadatadoesn't remove per-Request map, so mechanism should be manually cleaned up.Found in networkservicemesh/deployments-k8s#2381 (comment) logs:
forwarder_old_8.zip
How Has This Been Tested?
Types of changes