Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add netsvcmonitor chain element #1510

Merged
merged 3 commits into from
Sep 19, 2023
Merged

feat: add netsvcmonitor chain element #1510

merged 3 commits into from
Sep 19, 2023

Conversation

denis-tingaikin
Copy link
Member

Description

Fixes networkservicemesh/deployments-k8s#9767

Issue link

networkservicemesh/deployments-k8s#9767

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@denis-tingaikin denis-tingaikin changed the title feat; add netsvcmonitor chain element feat: add netsvcmonitor chain element Sep 13, 2023
@denis-tingaikin
add netsvcmonitor chain element
ec5e254 
Signed-off-by: Denis Tingaikin <[email protected]>
@codecov
Copy link

codecov bot commented Sep 17, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@f96fdf6). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1510   +/-   ##
=======================================
  Coverage        ?   70.24%           
=======================================
  Files           ?      248           
  Lines           ?    11203           
  Branches        ?        0           
=======================================
  Hits            ?     7870           
  Misses          ?     2835           
  Partials        ?      498

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denis-tingaikin
fix linter issues
46417c4 
Signed-off-by: Denis Tingaikin <[email protected]>
@denis-tingaikin denis-tingaikin marked this pull request as ready for review September 18, 2023 00:04
glazychev-art
glazychev-art approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@glazychev-art glazychev-art left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just one minor comment

pkg/networkservice/chains/nsmgr/suite_test.go Outdated Show resolved Hide resolved
@denis-tingaikin
apply review comments
1722084 
Signed-off-by: denis-tingaikin <[email protected]>
@glazychev-art glazychev-art merged commit bec8a85 into main Sep 19, 2023
17 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Sep 19, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
cf116e3 
…k@main

PR link: networkservicemesh/sdk#1510

Commit: bec8a85
Author: Denis Tingaikin
Date: 2023-09-19 06:25:39 +0300
Message:
  - feat: add netsvcmonitor chain element (#1510)
* add netsvcmonitor chain element

Signed-off-by: Denis Tingaikin <[email protected]>

* fix linter issues

Signed-off-by: Denis Tingaikin <[email protected]>

* apply review comments

Signed-off-by: denis-tingaikin <[email protected]>

---------

Signed-off-by: Denis Tingaikin <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Sep 19, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2ba9749 
…k@main

PR link: networkservicemesh/sdk#1510

Commit: bec8a85
Author: Denis Tingaikin
Date: 2023-09-19 06:25:39 +0300
Message:
  - feat: add netsvcmonitor chain element (#1510)
* add netsvcmonitor chain element

Signed-off-by: Denis Tingaikin <[email protected]>

* fix linter issues

Signed-off-by: Denis Tingaikin <[email protected]>

* apply review comments

Signed-off-by: denis-tingaikin <[email protected]>

---------

Signed-off-by: Denis Tingaikin <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Sep 19, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
7a5848e 
…k@main

PR link: networkservicemesh/sdk#1510

Commit: bec8a85
Author: Denis Tingaikin
Date: 2023-09-19 06:25:39 +0300
Message:
  - feat: add netsvcmonitor chain element (#1510)
* add netsvcmonitor chain element

Signed-off-by: Denis Tingaikin <[email protected]>

* fix linter issues

Signed-off-by: Denis Tingaikin <[email protected]>

* apply review comments

Signed-off-by: denis-tingaikin <[email protected]>

---------

Signed-off-by: Denis Tingaikin <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Sep 19, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
91f15b3 
…k@main

PR link: networkservicemesh/sdk#1510

Commit: bec8a85
Author: Denis Tingaikin
Date: 2023-09-19 06:25:39 +0300
Message:
  - feat: add netsvcmonitor chain element (#1510)
* add netsvcmonitor chain element

Signed-off-by: Denis Tingaikin <[email protected]>

* fix linter issues

Signed-off-by: Denis Tingaikin <[email protected]>

* apply review comments

Signed-off-by: denis-tingaikin <[email protected]>

---------

Signed-off-by: Denis Tingaikin <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Sep 19, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2064e1e 
…k@main

PR link: networkservicemesh/sdk#1510

Commit: bec8a85
Author: Denis Tingaikin
Date: 2023-09-19 06:25:39 +0300
Message:
  - feat: add netsvcmonitor chain element (#1510)
* add netsvcmonitor chain element

Signed-off-by: Denis Tingaikin <[email protected]>

* fix linter issues

Signed-off-by: Denis Tingaikin <[email protected]>

* apply review comments

Signed-off-by: denis-tingaikin <[email protected]>

---------

Signed-off-by: Denis Tingaikin <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Sep 19, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
17b4886 
…k@main

PR link: networkservicemesh/sdk#1510

Commit: bec8a85
Author: Denis Tingaikin
Date: 2023-09-19 06:25:39 +0300
Message:
  - feat: add netsvcmonitor chain element (#1510)
* add netsvcmonitor chain element

Signed-off-by: Denis Tingaikin <[email protected]>

* fix linter issues

Signed-off-by: Denis Tingaikin <[email protected]>

* apply review comments

Signed-off-by: denis-tingaikin <[email protected]>

---------

Signed-off-by: Denis Tingaikin <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Sep 19, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b197ffd 
…k@main

PR link: networkservicemesh/sdk#1510

Commit: bec8a85
Author: Denis Tingaikin
Date: 2023-09-19 06:25:39 +0300
Message:
  - feat: add netsvcmonitor chain element (#1510)
* add netsvcmonitor chain element

Signed-off-by: Denis Tingaikin <[email protected]>

* fix linter issues

Signed-off-by: Denis Tingaikin <[email protected]>

* apply review comments

Signed-off-by: denis-tingaikin <[email protected]>

---------

Signed-off-by: Denis Tingaikin <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Sep 19, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
fb38c14 
…k@main

PR link: networkservicemesh/sdk#1510

Commit: bec8a85
Author: Denis Tingaikin
Date: 2023-09-19 06:25:39 +0300
Message:
  - feat: add netsvcmonitor chain element (#1510)
* add netsvcmonitor chain element

Signed-off-by: Denis Tingaikin <[email protected]>

* fix linter issues

Signed-off-by: Denis Tingaikin <[email protected]>

* apply review comments

Signed-off-by: denis-tingaikin <[email protected]>

---------

Signed-off-by: Denis Tingaikin <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Sep 19, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f9d0f33 
…k@main

PR link: networkservicemesh/sdk#1510

Commit: bec8a85
Author: Denis Tingaikin
Date: 2023-09-19 06:25:39 +0300
Message:
  - feat: add netsvcmonitor chain element (#1510)
* add netsvcmonitor chain element

Signed-off-by: Denis Tingaikin <[email protected]>

* fix linter issues

Signed-off-by: Denis Tingaikin <[email protected]>

* apply review comments

Signed-off-by: denis-tingaikin <[email protected]>

---------

Signed-off-by: Denis Tingaikin <[email protected]>
Signed-off-by: NSMBot <[email protected]>
This was referenced Sep 19, 2023
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Sep 19, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
805f738 
…k@main

PR link: networkservicemesh/sdk#1510

Commit: bec8a85
Author: Denis Tingaikin
Date: 2023-09-19 06:25:39 +0300
Message:
  - feat: add netsvcmonitor chain element (#1510)
* add netsvcmonitor chain element

Signed-off-by: Denis Tingaikin <[email protected]>

* fix linter issues

Signed-off-by: Denis Tingaikin <[email protected]>

* apply review comments

Signed-off-by: denis-tingaikin <[email protected]>

---------

Signed-off-by: Denis Tingaikin <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Sep 19, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b903a5b 
…k@main

PR link: networkservicemesh/sdk#1510

Commit: bec8a85
Author: Denis Tingaikin
Date: 2023-09-19 06:25:39 +0300
Message:
  - feat: add netsvcmonitor chain element (#1510)
* add netsvcmonitor chain element

Signed-off-by: Denis Tingaikin <[email protected]>

* fix linter issues

Signed-off-by: Denis Tingaikin <[email protected]>

* apply review comments

Signed-off-by: denis-tingaikin <[email protected]>

---------

Signed-off-by: Denis Tingaikin <[email protected]>
Signed-off-by: NSMBot <[email protected]>
This was referenced Sep 19, 2023
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Sep 19, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
28c0cd5 
…k@main

PR link: networkservicemesh/sdk#1510

Commit: bec8a85
Author: Denis Tingaikin
Date: 2023-09-19 06:25:39 +0300
Message:
  - feat: add netsvcmonitor chain element (#1510)
* add netsvcmonitor chain element

Signed-off-by: Denis Tingaikin <[email protected]>

* fix linter issues

Signed-off-by: Denis Tingaikin <[email protected]>

* apply review comments

Signed-off-by: denis-tingaikin <[email protected]>

---------

Signed-off-by: Denis Tingaikin <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Sep 19, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
beb8d42 
…k@main

PR link: networkservicemesh/sdk#1510

Commit: bec8a85
Author: Denis Tingaikin
Date: 2023-09-19 06:25:39 +0300
Message:
  - feat: add netsvcmonitor chain element (#1510)
* add netsvcmonitor chain element

Signed-off-by: Denis Tingaikin <[email protected]>

* fix linter issues

Signed-off-by: Denis Tingaikin <[email protected]>

* apply review comments

Signed-off-by: denis-tingaikin <[email protected]>

---------

Signed-off-by: Denis Tingaikin <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Sep 19, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
3965ca7 
…k@main

PR link: networkservicemesh/sdk#1510

Commit: bec8a85
Author: Denis Tingaikin
Date: 2023-09-19 06:25:39 +0300
Message:
  - feat: add netsvcmonitor chain element (#1510)
* add netsvcmonitor chain element

Signed-off-by: Denis Tingaikin <[email protected]>

* fix linter issues

Signed-off-by: Denis Tingaikin <[email protected]>

* apply review comments

Signed-off-by: denis-tingaikin <[email protected]>

---------

Signed-off-by: Denis Tingaikin <[email protected]>
Signed-off-by: NSMBot <[email protected]>
This was referenced Sep 19, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Oct 3, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikitaSkrynnik NikitaSkrynnik NikitaSkrynnik approved these changes

@glazychev-art glazychev-art glazychev-art approved these changes

@edwarnicke edwarnicke Awaiting requested review from edwarnicke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reconnect services dynamically
3 participants
@denis-tingaikin @glazychev-art @NikitaSkrynnik