-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to change reselect function #1585
base: main
Are you sure you want to change the base?
Add an option to change reselect function #1585
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1585 +/- ##
=======================================
Coverage ? 67.27%
=======================================
Files ? 262
Lines ? 12464
Branches ? 0
=======================================
Hits ? 8385
Misses ? 3554
Partials ? 525 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test with a custom ReselectFunc?
dbf3870
to
abc0fc4
Compare
abc0fc4
to
e4bfbef
Compare
e4bfbef
to
6d27917
Compare
As I can see, CI failed 12 times in a row; it looks like we have problems with these changes. |
d05a912
to
445fe1e
Compare
64f7064
to
faf8151
Compare
faf8151
to
372da31
Compare
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
da53f35
to
13adb29
Compare
Description
Add an ability to change connection modifications during a reselect, because vl3 healing should not delete NSE name
Issue link
networkservicemesh/cmd-nse-vl3-vpp#289
How Has This Been Tested?
Types of changes