Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to change reselect function #1585

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

NikitaSkrynnik
Copy link
Contributor

@NikitaSkrynnik NikitaSkrynnik commented Feb 12, 2024

Description

Add an ability to change connection modifications during a reselect, because vl3 healing should not delete NSE name

Issue link

networkservicemesh/cmd-nse-vl3-vpp#289

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@608b1b5). Click here to learn what that means.

❗ Current head dbf3870 differs from pull request most recent head abc0fc4. Consider uploading reports for the commit abc0fc4 to get more accurate results

Files Patch % Lines
pkg/networkservice/common/begin/options.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1585   +/-   ##
=======================================
  Coverage        ?   67.27%           
=======================================
  Files           ?      262           
  Lines           ?    12464           
  Branches        ?        0           
=======================================
  Hits            ?     8385           
  Misses          ?     3554           
  Partials        ?      525           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@glazychev-art glazychev-art left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test with a custom ReselectFunc?

@denis-tingaikin
Copy link
Member

As I can see, CI failed 12 times in a row; it looks like we have problems with these changes.

@NikitaSkrynnik NikitaSkrynnik force-pushed the vl3-healing branch 2 times, most recently from d05a912 to 445fe1e Compare September 30, 2024 07:57
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants