Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expire registry chain element should correctly set expiration time #654

Merged
merged 2 commits into from
Jan 15, 2021
Merged

fix: expire registry chain element should correctly set expiration time #654

merged 2 commits into from
Jan 15, 2021

Conversation

denis-tingaikin
Copy link
Member

Signed-off-by: Denis Tingaikin [email protected]

Description

If the next of the expire chain element do remote register then expire not set the expiration time for the response.

@denis-tingaikin
apply review comments
0bc04c4 
Signed-off-by: Denis Tingaikin <[email protected]>
@haiodo haiodo merged commit 977c1ae into networkservicemesh:master Jan 15, 2021
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder that referenced this pull request Jan 15, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
91c754e 
…k@master networkservicemesh/sdk#654

networkservicemesh/sdk PR link: networkservicemesh/sdk#654

networkservicemesh/sdk commit message:
commit 977c1aec2f6961b1c32efdfaa92c08d4e2e9c4b4
Author: Denis Tingaikin <[email protected]>
Date:   Fri Jan 15 16:10:07 2021 +0700

    fix: expire registry chain element should correctly set expiration time (#654)

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Jan 15, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
3199503 
…k@master networkservicemesh/sdk#654

networkservicemesh/sdk PR link: networkservicemesh/sdk#654

networkservicemesh/sdk commit message:
commit 977c1aec2f6961b1c32efdfaa92c08d4e2e9c4b4
Author: Denis Tingaikin <[email protected]>
Date:   Fri Jan 15 16:10:07 2021 +0700

    fix: expire registry chain element should correctly set expiration time (#654)

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Jan 15, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9bfe1c3 
…k@master networkservicemesh/sdk#654

networkservicemesh/sdk PR link: networkservicemesh/sdk#654

networkservicemesh/sdk commit message:
commit 977c1aec2f6961b1c32efdfaa92c08d4e2e9c4b4
Author: Denis Tingaikin <[email protected]>
Date:   Fri Jan 15 16:10:07 2021 +0700

    fix: expire registry chain element should correctly set expiration time (#654)

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Jan 15, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
15195e9 
…k@master networkservicemesh/sdk#654

networkservicemesh/sdk PR link: networkservicemesh/sdk#654

networkservicemesh/sdk commit message:
commit 977c1aec2f6961b1c32efdfaa92c08d4e2e9c4b4
Author: Denis Tingaikin <[email protected]>
Date:   Fri Jan 15 16:10:07 2021 +0700

    fix: expire registry chain element should correctly set expiration time (#654)

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Jan 15, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c58c39a 
…k@master networkservicemesh/sdk#654

networkservicemesh/sdk PR link: networkservicemesh/sdk#654

networkservicemesh/sdk commit message:
commit 977c1aec2f6961b1c32efdfaa92c08d4e2e9c4b4
Author: Denis Tingaikin <[email protected]>
Date:   Fri Jan 15 16:10:07 2021 +0700

    fix: expire registry chain element should correctly set expiration time (#654)

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Jan 15, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
609d99b 
…k@master networkservicemesh/sdk#654

networkservicemesh/sdk PR link: networkservicemesh/sdk#654

networkservicemesh/sdk commit message:
commit 977c1aec2f6961b1c32efdfaa92c08d4e2e9c4b4
Author: Denis Tingaikin <[email protected]>
Date:   Fri Jan 15 16:10:07 2021 +0700

    fix: expire registry chain element should correctly set expiration time (#654)

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-vpp that referenced this pull request Jan 15, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
05c25f5 
…k@master networkservicemesh/sdk#654

networkservicemesh/sdk PR link: networkservicemesh/sdk#654

networkservicemesh/sdk commit message:
commit 977c1aec2f6961b1c32efdfaa92c08d4e2e9c4b4
Author: Denis Tingaikin <[email protected]>
Date:   Fri Jan 15 16:10:07 2021 +0700

    fix: expire registry chain element should correctly set expiration time (#654)

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Jan 15, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
55a1ada 
…k@master networkservicemesh/sdk#654

networkservicemesh/sdk PR link: networkservicemesh/sdk#654

networkservicemesh/sdk commit message:
commit 977c1aec2f6961b1c32efdfaa92c08d4e2e9c4b4
Author: Denis Tingaikin <[email protected]>
Date:   Fri Jan 15 16:10:07 2021 +0700

    fix: expire registry chain element should correctly set expiration time (#654)

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-vppagent that referenced this pull request Jan 15, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
4ed396b 
…k@master networkservicemesh/sdk#654

networkservicemesh/sdk PR link: networkservicemesh/sdk#654

networkservicemesh/sdk commit message:
commit 977c1aec2f6961b1c32efdfaa92c08d4e2e9c4b4
Author: Denis Tingaikin <[email protected]>
Date:   Fri Jan 15 16:10:07 2021 +0700

    fix: expire registry chain element should correctly set expiration time (#654)

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Jan 15, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
01cc744 
…k@master networkservicemesh/sdk#654

networkservicemesh/sdk PR link: networkservicemesh/sdk#654

networkservicemesh/sdk commit message:
commit 977c1aec2f6961b1c32efdfaa92c08d4e2e9c4b4
Author: Denis Tingaikin <[email protected]>
Date:   Fri Jan 15 16:10:07 2021 +0700

    fix: expire registry chain element should correctly set expiration time (#654)

Signed-off-by: NSMBot <[email protected]>
This was referenced Jan 15, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bolodya1997 Bolodya1997 Bolodya1997 left review comments

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denis-tingaikin @haiodo @Bolodya1997