-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GigX/X/X support and Duplex a-half interface support. #108
Conversation
Fix - Add GigX/X/X support - Catalyst Stack Support, like 2960X. Fix - 2950s report half duplex as “a-half”. Added variety of test results to the raw parser test.
Just run |
Removed Fa0 entry from raw test.
Sorry, I had fully run a test on it before a last minute change. At the last minute I decided about removing Fa0 management interface out of this PR. Which is not included in this PR. |
I think the problem is actually that you're modifying parsed and raw files but not fixing the template accordingly (or simply not including it in this PR :) ) I've just used this template and worked with and without the Fa0 interface
|
Original name string Value NAME (\S+(\s\w+\s\w+)?) fails to match descriptions with ‘ in the description like this Gi2/0/46 Jerrick Kellum's P connected 16 a-full a-100 10/100/1000BaseTX Adjusted to .* to match symbols in the description field.
I see the failure, I will try to run the test script on my side and post an update. I ran into a new change today and tried to work it in. |
I think this may be a bit cleaner, let me know what you think?
|
Thanks itdependsnetworks for the regex recommendation.
Excellent - much more readable. I tested it locally, and have added it to the PR. |
Looks good to me, thanks @jasonbarbee ! |
Fix - Add GigX/X/X support - Catalyst Stack Support, like 2960X.
Fix - 2950s report half duplex as “a-half”.
Added variety of test results to the raw parser test.