Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First round of Brocade Fastiron and Netiron templates and associated tests #112

Merged
merged 5 commits into from
Apr 7, 2017

Conversation

davesill
Copy link

@davesill davesill commented Apr 6, 2017

ISSUE TYPE

New Template Pull Request

COMPONENT

brocade_fastiron_show_interfaces.template
brocade_fastiron_show_interfaces_brief.template
brocade_fastiron_show_lag_brief.template
brocade_fastiron_show_lldp_neighbors_detail.template
brocade_fastiron_show_metro.template
brocade_fastiron_show_monitor.template
brocade_fastiron_show_run_vlan.template
brocade_fastiron_show_span.template
brocade_fastiron_show_topo.template
brocade_fastiron_show_trunk.template
brocade_netiron_show_interfaces.template
brocade_netiron_show_interfaces_brief.template
brocade_netiron_show_lag_brief.template
brocade_netiron_show_lldp_neighbors_detail.template
brocade_netiron_show_metro.template
brocade_netiron_show_monitor.template
brocade_netiron_show_run_int_ve.template
brocade_netiron_show_run_vlan.template
brocade_netiron_show_span.template
brocade_netiron_show_topo.template

SUMMARY

Added initial Brocade Fastiron and Netiron templates and associated tests.

@itdependsnetworks
Copy link
Contributor

Looks really good. We try to use capital letters for variable definitions but have not been strict on enforcing.

Should be able to get away with:
([eE]nabled|[dD]isabled)

for come of the case insensitive. issues.

I'll see if @GGabriele is nice enough to fix index file since a push has been made since :)

@davesill
Copy link
Author

davesill commented Apr 6, 2017

Thanks @itdependsnetworks. I'll be sure to roll all caps variable names next time.

@GGabriele GGabriele mentioned this pull request Apr 7, 2017
@GGabriele GGabriele merged commit a4829fb into networktocode:master Apr 7, 2017
@GGabriele
Copy link
Contributor

That's awesome, thanks! @davesill
Merged with #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants