Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated support for Cisco NXOS devices #1175

Merged
merged 4 commits into from
Apr 14, 2023
Merged

Updated support for Cisco NXOS devices #1175

merged 4 commits into from
Apr 14, 2023

Conversation

ReK42
Copy link
Contributor

@ReK42 ReK42 commented Jul 29, 2022

ISSUE TYPE
  • New Template Pull Request
COMPONENT
  • show_ip_ospf_interface_brief
  • show_ip_pim_rp_vrf
  • show_ip_pim_neighbor_vrf
  • show_ip_pim_interface_brief_vrf
  • show_ip_pim_group-range_vrf
SUMMARY

Added 5 new commands.

See tests for command output.

@ReK42
Copy link
Contributor Author

ReK42 commented Jul 29, 2022

There appears to be a problem with the Python 3.7 test environment, Travis is showing The command "poetry install" failed. Tests are passing for 3.6 and 3.8.

@jvanderaa
Copy link
Contributor

Restarted the build that failed still.

Will continue to check on that, but also missing the ERROR statement.

@ReK42
Copy link
Contributor Author

ReK42 commented Aug 15, 2022

Looks like the environment is failing to be installed:

• Installing future (0.18.2): Installing...

  • Installing mccabe (0.6.1): Failed

  EnvCommandError

  Command ['/home/travis/virtualenv/python3.7.1/bin/pip', 'install', '--no-deps', '/home/travis/.cache/pypoetry/artifacts/c2/cd/ed/3c4495a1422fb12eefbca8b3c6ccc83ab4ec92fd39df029199cc4f4ee4/mccabe-0.6.1-py2.py3-none-any.whl'] errored with the following return code 1, and output: 

  Processing /home/travis/.cache/pypoetry/artifacts/c2/cd/ed/3c4495a1422fb12eefbca8b3c6ccc83ab4ec92fd39df029199cc4f4ee4/mccabe-0.6.1-py2.py3-none-any.whl

  Installing collected packages: mccabe

  ERROR: Could not install packages due to an OSError: [Errno 2] No such file or directory: '/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/packaging-20.9.dist-info'

pszulczewski
pszulczewski requested changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@pszulczewski pszulczewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ReK42 can you re-base this PR on master.
CI is now fixed.

@ReK42 ReK42 closed this Apr 13, 2023
@ReK42
Copy link
Contributor Author

ReK42 commented Apr 13, 2023

It looks like someone else added one of the commands in the meantime. I've removed that but kept the show ip pim commands. Note that due to the length of time since the original PR I no longer have an environment to test this in.

@ReK42 ReK42 reopened this Apr 13, 2023
@ReK42 ReK42 requested a review from pszulczewski April 14, 2023 00:01
pszulczewski
pszulczewski requested changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@pszulczewski pszulczewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add ^. -> Error at the end of each template so there is an error raised instead of an empty result and we are good to merge ;-)
Thank you!

ntc_templates/templates/cisco_nxos_show_ip_pim_group-range_vrf_all.textfsm Outdated Show resolved Hide resolved
ntc_templates/templates/cisco_nxos_show_ip_pim_interface_brief_vrf_all.textfsm Outdated Show resolved Hide resolved
ntc_templates/templates/cisco_nxos_show_ip_pim_neighbor_vrf_all.textfsm Outdated Show resolved Hide resolved
ntc_templates/templates/cisco_nxos_show_ip_pim_rp_vrf_all.textfsm Outdated Show resolved Hide resolved
pszulczewski
pszulczewski approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@pszulczewski pszulczewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK looks like I was able to make the necessary changes myself.

Many thanks for your contribution and apologies that it took so long to merge it.

@pszulczewski pszulczewski merged commit aa4f23f into networktocode:master Apr 14, 2023
cppmonkey pushed a commit to cppmonkey/ntc-templates that referenced this pull request Oct 25, 2023
@ReK42 @pszulczewski @cppmonkey
Updated support for Cisco NXOS devices (networktocode#1175)
e9bdd5b 
* Add support for four nxos commands under show ip pim

---------

Co-authored-by: Patryk Szulczewski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pszulczewski pszulczewski pszulczewski approved these changes

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks is a code owner

@jmcgill298 jmcgill298 Awaiting requested review from jmcgill298 jmcgill298 is a code owner

@FragmentedPacket FragmentedPacket Awaiting requested review from FragmentedPacket

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

Assignees
No one assigned
Labels
patryk-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ReK42 @jvanderaa @pszulczewski @itdependsnetworks