Standardize router mac (rmac) capture group to mac_address #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… MAC address in the output anyways)
mjbear
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
cppmonkey
pushed a commit
to cppmonkey/ntc-templates
that referenced
this pull request
Oct 25, 2023
…code#1422) replace RMAC with MAC_ADDRESS (to standardize, plus there is only one MAC address in the output anyways)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize/normalize the capture group name from RMAC to MAC_ADDRESS.
There's only a single MAC address in the raw output and template so this normalizes and does not introduce unique more lengthy capture group names.
Breaking change on account of the capture group change
(sixth of 8/2023 PRs)