-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize capture group to PREFIX_LENGTH #1432
Merged
jvanderaa
merged 13 commits into
networktocode:master
from
mjbear:standardize_capture_group_prefix_length
Aug 8, 2023
Merged
Standardize capture group to PREFIX_LENGTH #1432
jvanderaa
merged 13 commits into
networktocode:master
from
mjbear:standardize_capture_group_prefix_length
Aug 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbear
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
August 7, 2023 12:24
jvanderaa
approved these changes
Aug 7, 2023
…DDRESS and PREFIX_LENGTH
…ts IP_ADDRESS and PREFIX_LENGTH
…o its parts IP_ADDRESS and PREFIX_LENGTH
… IP_ADDRESS and PREFIX_LENGTH
…IP_ADDRESS and PREFIX_LENGTH
lengths (numbers in slash notation)
(alcatel_sros_show_router_bgp_routes_vpn-ipv4)
mjbear
force-pushed
the
standardize_capture_group_prefix_length
branch
from
August 8, 2023 01:38
7eeb79d
to
3622556
Compare
rebasing against current NTC upstream/master branch |
jvanderaa
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize/normalize capture group for prefix notation to be PREFIX_LENGTH
Breaking change on account of the capture group changes
(seventeenth of 8/2023 PRs)