-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Edgecore platform with 7 templates #1463
Conversation
@itdependsnetworks @jmcgill298 @jvanderaa Should I make separate PR for each template when it's totally new device platform? |
Generally we are going for one PR per template update/inclusion for discussion sake. At this point that is water under the bridge and keep this in place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting a few changes to align with some of the existing templates, which will allow in a multi-vendor environment to have the transformation of keys to being the same without requiring it in an ETL process.
ntc_templates/templates/edgecore_show_interfaces_status.textfsm
Outdated
Show resolved
Hide resolved
ntc_templates/templates/edgecore_show_interfaces_status.textfsm
Outdated
Show resolved
Hide resolved
ntc_templates/templates/edgecore_show_interfaces_status.textfsm
Outdated
Show resolved
Hide resolved
Co-authored-by: Josh VanDeraa <[email protected]>
Co-authored-by: Josh VanDeraa <[email protected]>
Co-authored-by: Josh VanDeraa <[email protected]>
Co-authored-by: Josh VanDeraa <[email protected]>
@jvanderaa Tests are failing because of tests/cisco_ios/show_ip_interface/cisco_ios_show_ip_interface7.yml. I've made PR, which fixed it |
Can this be merged? |
I'm keen for this to be merged but I gave it a test and found an issue: I have edgecores with SFP ports, which report the type as '10GBASE SFP+' - the templates don't work with this due to the space. Changing TYPE to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @PavloSkliarenko
Templates for Edgecore commands:
show interfaces brief
show interfaces status
show interfaces switchport
show ip interface
show system
show version
show vlan