Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Edgecore platform with 7 templates #1463

Merged
merged 23 commits into from
Jul 22, 2024

Conversation

PavloSkliarenko
Copy link
Contributor

Templates for Edgecore commands:

show interfaces brief
show interfaces status
show interfaces switchport
show ip interface
show system
show version
show vlan

@PavloSkliarenko
Copy link
Contributor Author

@itdependsnetworks @jmcgill298 @jvanderaa Should I make separate PR for each template when it's totally new device platform?

@jvanderaa
Copy link
Contributor

Generally we are going for one PR per template update/inclusion for discussion sake. At this point that is water under the bridge and keep this in place.

Copy link
Contributor

@jvanderaa jvanderaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a few changes to align with some of the existing templates, which will allow in a multi-vendor environment to have the transformation of keys to being the same without requiring it in an ETL process.

@PavloSkliarenko
Copy link
Contributor Author

@jvanderaa Tests are failing because of tests/cisco_ios/show_ip_interface/cisco_ios_show_ip_interface7.yml. I've made PR, which fixed it

@AlexLardschneider
Copy link
Contributor

Can this be merged?

@samk-acw
Copy link

I'm keen for this to be merged but I gave it a test and found an issue: I have edgecores with SFP ports, which report the type as '10GBASE SFP+' - the templates don't work with this due to the space. Changing TYPE to (.*?) seems to fix it.

Copy link
Contributor

@jmcgill298 jmcgill298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmcgill298 jmcgill298 dismissed jvanderaa’s stale review July 22, 2024 14:46

resolved by owner

@jmcgill298 jmcgill298 merged commit b726498 into networktocode:master Jul 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants