cisco_xr_show_ipv4_interface: Add new attributes, update index #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the index so "v4" as part of the command is optional. "show ip interface" returns the same as "show ipv4 interface". Make IP_ADDRESS a list. Add PREFIX_LENGTH, IP_MTU, MULTICAST_GROUPS.
Remove List type from ip_address and prefix_length.
lamiskin
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
|
This would be a breaking change, as the IP_ADDRESS no longer includes the prefix length. |
jvanderaa
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the index so "v4" as part of the command is optional.
"show ip interface" returns the same as "show ipv4 interface".
Add PREFIX_LENGTH, IP_MTU, MULTICAST_GROUPS.
Including relevant tests.
Related to #1601