Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CISCO_IOS_SHOW_VLAN: Add support for capturing interfaces associated … #210

Merged
merged 2 commits into from
May 26, 2018

Conversation

jmcgill298
Copy link
Contributor

…with each vlan

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT

cisco_ios_show_vlan

SUMMARY

Add support for capturing interfaces associated with each vlan

Fixes #175


^\d+ -> Continue.Record
^${VLAN_ID}\s+${NAME}\s+${STATUS}\s*$$
^${VLAN_ID}\s+${NAME}\s+${STATUS}\s+${INTERFACES},* -> Continue
^\d+\s+(?:\S+\s+){3}${INTERFACES},* -> Continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner, kinda mad I didn't think of this before.

^\s+(?:\S+\s+){9}${INTERFACES},* -> Continue
^\s+(?:\S+\s+){10}${INTERFACES},* -> Continue
^\s+(?:\S+\s+){11}${INTERFACES} -> Continue
^\d+ -> VLANS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems redundant from the one below and first one in VLANs. Also is the self referencing state change needed?

@jmcgill298
Copy link
Contributor Author

@itdependsnetworks I removed the state change, should be good now

@itdependsnetworks itdependsnetworks merged commit 380a0de into networktocode:master May 26, 2018
@jmcgill298 jmcgill298 deleted the ios_vlan branch October 12, 2018 03:14
jvanderaa pushed a commit that referenced this pull request Nov 10, 2021
CISCO_IOS_SHOW_VLAN: Add support for capturing interfaces associated …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template update: cisco_ios_show_vlan to get interface list
2 participants