Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template for "show ip eigrp neighbors" on Cisco IOS #285

Merged
merged 19 commits into from
Nov 6, 2018
Merged

Add template for "show ip eigrp neighbors" on Cisco IOS #285

merged 19 commits into from
Nov 6, 2018

Conversation

Tachashi
Copy link
Contributor

@Tachashi Tachashi commented Nov 5, 2018

ISSUE TYPE
  • New Template Pull Request
COMPONENT

cisco_ios_show_ip_eigrp_neighbors.template

SUMMARY

This is adding a template for show ip eigrp neighbors that structures the following data:
Address
Interface
Hold
Uptime
SRTT
RTO
Q_Cnt
Seq_Num


Copy link
Contributor

@jmcgill298 jmcgill298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested my suggestions, so I might have something off with them. It is important that we match all of the data to ensure we are reporting accurately. TextFSM has an Error state that we use in case we come across a line in the raw data that we cannot parse.

templates/cisco_ios_show_ip_eigrp_neighbors.template Outdated Show resolved Hide resolved
templates/cisco_ios_show_ip_eigrp_neighbors.template Outdated Show resolved Hide resolved
templates/cisco_ios_show_ip_eigrp_neighbors.template Outdated Show resolved Hide resolved
templates/cisco_ios_show_ip_eigrp_neighbors.template Outdated Show resolved Hide resolved
@jmcgill298
Copy link
Contributor

@Tachashi I put a PR in to your fork to add back your original test data.

In the future, you can install pytest and run that to test the modifications before making your commits; that is a little more convenient than waiting to see if the tests pass on GitHub.

@jmcgill298 jmcgill298 merged commit 7808799 into networktocode:master Nov 6, 2018
jmcgill298 pushed a commit to jmcgill298/ntc-templates that referenced this pull request Nov 6, 2018
jmcgill298 pushed a commit to jmcgill298/ntc-templates that referenced this pull request Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants