Add INPUT_PACKETS, INPUT_ERRORS, OUTPUT_PACKETS, OUTPUT_ERRORS fields to cisco_ios_show_interfaces & cisco_nxos_show_interface templates #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcgill298
requested changes
Dec 31, 2018
There was a problem hiding this comment.
@Enzzzy It is easy for extra space characters to be missed, so I like to be more generous with matching spaces. \s should be \s+ and end-of-line should allow for spaces, \s*.
…isco_ios_show_interfaces & cisco_nxos_show_interface templates * Updated cisco_ios_show_interfaces & cisco_nxos_show_interface tests, to take the new fields into account.
wvandeun
force-pushed
the
feature_add_interface_input_out_packets_errors_ios_nxos
branch
from
8a8c196
to
9926451
Compare
|
@jmcgill298 I have made all the requested changes. |
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
…isco_ios_show_interfaces & cisco_nxos_show_interface templates (#307) * Updated cisco_ios_show_interfaces & cisco_nxos_show_interface tests, to take the new fields into account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
cisco_ios_show_interfaces.template, cisco_ios, show interfaces
cisco_nxos_show_interface.template, cisco_nxos, show interface
SUMMARY