Updated LLDP Neighbor Detail for matching on some devices that were missing. #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to match that which was tested for catching all neighbors. This is to update to take care of the 4th raw parsing.
Previously:
`System Name: ZULTYS IP Phone` is not matching `^System\s+Name(?::\s+${NEIGHBOR}|\s+-\s+not\s+advertised)\s*$$`
|
Can you provide a full output? Not having the headers and footers (total entries) can make it lose context in the future. I realize not all of these have it, but would like to set a better precedence moving forward. |
added 2 commits
February 20, 2019 15:44
…ngine with single entry LLDP output including Header/footer
…ngine with single entry LLDP output including Header/footer
|
I need to delete commit e62f049 from this. Working on figuring out the proper way to do that since I didn't branch properly on the fork. |
jmcgill298
requested changes
Feb 23, 2019
tests/cisco_ios/show_lldp_neighbors_detail/cisco_ios_show_lldp_neighbors_detail4.raw
Outdated
Show resolved
Hide resolved
Co-Authored-By: jvanderaa <[email protected]>
…_neighbors_detail4.raw Co-Authored-By: jvanderaa <[email protected]>
jmcgill298
approved these changes
Feb 23, 2019
jvanderaa
added a commit
that referenced
this pull request
Nov 10, 2021
New LLDP output shows that the neighbor's hostname field might: 1) Be empty 2) Have spaces in the name Template Updates: - Add Regex matching to account for a device with an empty `System Name` field - Change `NEIGHBOR` capture group to use `.+?` to allow for spaces in the name Test Files: - Add additional raw and parsed files to test for updated info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
cisco_ios_show_lldp_neighbors_detail.template
SUMMARY
Before
After