-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes 374 - Adds example of Other/unknown media on LLDP for a device … #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the raw, and a proposed fix
I'm not exactly sure how the Travis CI is failing here. I believe that I have the text in the raw files as expected. Everything checks out on the Ansible test. Guidance/help is appreciated. |
Looks like the issue is with reading the file cisco_ios_show_lldp_neighbors_detail4
|
I see now. Will update and fix tonight yet. |
My attempt at linking the two (issue to PR) Fixes #374 |
jvanderaa
added a commit
that referenced
this pull request
Nov 10, 2021
#377) * Updated cisco_ios_show_lldp_neighbor_detail template with lenient accountancy for physical media capabilities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to the raw, and a proposed fix
ISSUE TYPE
COMPONENT
cisco_ios_show_lldp_neighbors_detail
SUMMARY
The change removed a search string that was looking for
(text)
within the media type. This would not match on:Changes
^\s+.+\(\S+\)\s*$$
to^\s+.+\s*$$
and added comments.Before
After