Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cisco_ios_show_ip_eigrp_topology.template #445

Merged
merged 11 commits into from
Oct 7, 2019

Conversation

thomasbridge74
Copy link
Contributor

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT

cisco_ios_show_ip_eigrp_topology.template

SUMMARY

When I used the show ip eigrp topology template for the first time, I ran into errors. There were two cases where the current template failed:

  1. Where the route had an inaccessible FD rather than a number, the template choked on the input because it was matching FD on a number.
  2. More significantly, the script would also throw an error on routes that had been entered into the local EIGRP topology database via redistribution - it failed where the via was via Rstatic or Redistributed.

I've update the raw input file and the expected parsed input to test for these scenarios. The result of this updated is an additional field (source) at the end that would be null for ordinary routes but will indicated whether the route is learned via Rstatic or Redistributed.

@thomasbridge74 thomasbridge74 changed the title Ip eigrp Update cisco_ios_show_ip_eigrp_topology.template Aug 19, 2019
Copy link
Contributor

@FragmentedPacket FragmentedPacket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasbridge74 Thanks for your submission!

Instead of changing the original raw and parsed, could you please add new ones that indicate your use case? This allows us to ensure backwards compatibility and have more (data) test cases

@FragmentedPacket FragmentedPacket added changes_requested Waiting on user to address feedback enhancement labels Sep 27, 2019
@thomasbridge74
Copy link
Contributor Author

@thomasbridge74 Thanks for your submission!

Instead of changing the original raw and parsed, could you please add new ones that indicate your use case? This allows us to ensure backwards compatibility and have more (data) test cases

Hi - one of the "enhancements" I've made to the TextFSM template is to add an extra field (SOURCE) to parse if the next hop is learned through Static or Redistribution (and is blank if a normal EIGRP route). I've reverted my repository to use the original raw file, but I will need to modify that parsed file to use the new field (which is blank for all the cases) as otherwise it will fail the unit testing. Is this acceptable?

Thanks,

Thomas

@FragmentedPacket FragmentedPacket merged commit ca10687 into networktocode:master Oct 7, 2019
@thomasbridge74 thomasbridge74 deleted the ip_eigrp branch October 7, 2019 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes_requested Waiting on user to address feedback enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants