-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cisco_ios_show_ip_eigrp_topology.template #445
Update cisco_ios_show_ip_eigrp_topology.template #445
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomasbridge74 Thanks for your submission!
Instead of changing the original raw and parsed, could you please add new ones that indicate your use case? This allows us to ensure backwards compatibility and have more (data) test cases
Hi - one of the "enhancements" I've made to the TextFSM template is to add an extra field (SOURCE) to parse if the next hop is learned through Static or Redistribution (and is blank if a normal EIGRP route). I've reverted my repository to use the original raw file, but I will need to modify that parsed file to use the new field (which is blank for all the cases) as otherwise it will fail the unit testing. Is this acceptable? Thanks, Thomas |
…d test file as seperate from the new tests.
ISSUE TYPE
COMPONENT
cisco_ios_show_ip_eigrp_topology.template
SUMMARY
When I used the show ip eigrp topology template for the first time, I ran into errors. There were two cases where the current template failed:
I've update the raw input file and the expected parsed input to test for these scenarios. The result of this updated is an additional field (source) at the end that would be null for ordinary routes but will indicated whether the route is learned via Rstatic or Redistributed.