-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ruckus_fastiron show arp template #493
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed whitespace regex
better address whitespace
Noticing that perhaps the raw and parsed outputs numbered 1 have quite a few lines, could probably do to remove some of those. |
FragmentedPacket
suggested changes
Oct 14, 2019
FragmentedPacket
added
changes_requested
Waiting on user to address feedback
New Template
labels
Oct 14, 2019
FragmentedPacket
suggested changes
Oct 14, 2019
Update template states to key correct data
FragmentedPacket
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
Added ruckus_fastiron_show_arp.template
SUMMARY
Added ruckus_fastiron show arp command template, accounting for both the Layer 2 and Layer 3 software versions (numberless and 1 raw outputs respectively).
Tried to minimize the amount of lines used for different headers by catching both OS lines if syntax was similar. Had to create multiple lines for the actual data capture as Layer 3 OS does not report VLAN information.
MAC Address has the potential to be 'None', wanted to capture that information as well.