New Template: hp_comware_display_ip_routing-table & hp_comware_display_device_manuinfo #623
Conversation
There was a problem hiding this comment.
@xdai555 Can you please add matches for each line of text, and end each State with:
^\s*$$
^. -> Error
|
The 'display ip routing-table' template needs to match each line, add '^. -> Error' is useless. |
This is not useless, as the intent is to catch output that is different from the known output and report back which line is not being captured. CLI output is known to vary between platforms, OS versions, and rare conditions that alter table data. Even knowing that this would account for all data today, it doesn't ensure that future updates will comply. |
|
@xdai555 As Jacob said, those are something we require and it does help ensure when the output changes, it will throw an error and help locate the difference in output when trying to troubleshoot the template in the future. Please update the templates to NTC Templates standard and then we'll get this merged in. |
|
@FragmentedPacket @jmcgill298 I have some problems these days and now they have been solved. |
| ^\s?MAC_ADDRESS\s*:\s*${MAC_ADDRESS} | ||
| ^\s?MANUFACTURING_DATE\s*:\s*${MANUFACTURING_DATE} | ||
| ^\s?VENDOR_NAME\s*:\s*${VENDOR_NAME} -> Record Start | ||
| ^. -> Error |
There was a problem hiding this comment.
Do you mind adding ^\s*$$ above the error line?
Do you mind also changing the beginning \s? to \s* just in case they do change to more than one space at the beginning?
Those should be the last changes and then we can get these merged in.
There was a problem hiding this comment.
I will follow the format next time.
Practice makes perfect. ^_^
|
Thanks @xdai555 |
ISSUE TYPE
COMPONENT
SUMMARY
Reference: cisco_ios_show_ip_route
The following device types have been tested: