Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for broadcom_icos command show_mac-address-table #736

Merged
merged 2 commits into from
Jun 5, 2020
Merged

Conversation

alepodj
Copy link
Contributor

@alepodj alepodj commented Jun 2, 2020

ISSUE TYPE
  • New Template Pull Request
COMPONENT

broadcom_icos_show_mac-address-table.textfsm
broadcom_icos
show_mac-address-table

SUMMARY

Added support for broadcom_icos command show_mac-address-table

# Accton AS4610-54P, Accton AS5610-52X, Quanta LY2R, Quanta LB9, DNI AG3448P-R
# Raw data is the same in the case of all those devices
^\s*VLAN\s+ID\s+MAC\s+Address\s+Interface\s+IfIndex\s+Status
^-+ -+ -+ -+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
^-+ -+ -+ -+
^-+

I would remove the extra ones as they mark the headers as you have already made sure they exist.

Do you mind also adding the following right above the error line:

  ^\s*$$

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected as requested

@FragmentedPacket FragmentedPacket added the changes_requested Waiting on user to address feedback label Jun 5, 2020
@FragmentedPacket FragmentedPacket merged commit f201c35 into networktocode:master Jun 5, 2020
thomasblass pushed a commit to thomasblass/ntc-templates that referenced this pull request Oct 25, 2020
guillaume-mbali pushed a commit to unyc-io/ntc-templates that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes_requested Waiting on user to address feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants