Fixed test-template.yml to run in Ansible 2.3 #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the variable setup so it only prompts for template name and creates the platform from that argument. Fixed TEST_DIR to default to below the current working directory. Assumes playbook run from ntc-templates folder. Closes networktocode#73
|
Well, tests pass in Ansible 1.9.2 as well. Didn't realize the CI was using this older version -- perhaps that was my problem in #73? What are the plans to update? Edit: I realize that the playbook isn't used in Travis CI, so that's kind of a silly point. Looks like the API changes in 2.0 may be why this hasn't been updated in some time as the test-templates.py would need to be rewritten. It would likely need the changes to compare_dict I was testing in the other branch as well. Anyone working the API conversion? |
|
There has been discussion and a pending PR to help with testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
test-template.yml
SUMMARY
Changed the variable setup so it only prompts for template name and
creates the platform from that argument. Fixed TEST_DIR to default
to below the current working directory. Assumes playbook run from
ntc-templates folder.
Closes #73