Fix issues #15 (double-accounting) and #16 (continued mix-up of DSBC goals and labels) #18

jimklimov · 2023-07-10T17:30:40Z

Closes: #16
Closes: #15

Also should reduce the appearance of duplicate (or otherwise similar) "yellow badge" reports in Build History column by more diligent clean-up attempts before posting the latest update (parallel code races).

…with variable inputs

* Avoid mess-up of static/reusable vs. dynamic variables * Use stricter types where possible instead of "def" (watch out for fallout!) * Revise Set of Lists (as Tuples) vs. Maps for parallel stage preparation

…one()

…ents

… explicit .call() for compiler warnings

…atch()

…s and strings like ABORTED_SAFE

…ageTimeoutSettings is not a Map

… Set normally

…e (also if it is a method reference)

… org.jenkinsci.plugins.workflow.cps.EnvActionImpl

…can do better

…dsbc and stageName (static clone!) objects as in bodyData[] [#16]

…nal dsbc object, not a clone()

…) the shared definition and rehydrate() to make a unique Closure instance Finally! Probably this is what fixes #16 (at least test runs do look better)

…rix object identifier

…Result

… Dynamatrix object identifier and avoid printing "Not all went well: [:]" if possible

…ynacfg*[] involved

… repeat details of dynacfg*[] involved

…ause a getter is also available

…ts (getWorstResult, verdict counters, etc.)

…o countStagesIncrementSync()

…e, countStagesIncrement) with this.shouldDebugTrace()

… if recursing

…before publishing ours, to minimize dupes

…(seems they have a way to store stats into parent after all)

Fix reporting of quick-test phase failures and some fallout from #18

jimklimov added 30 commits July 9, 2023 17:18

Dynamatrix.groovy: try to avoid accounting ABORTED_SAFE twice [#15]

dc61ec0

Dynamatrix.groovy: add poor-mans debugging of countStagesIncrement() …

817e7e8

…with variable inputs

Define used variable types in more places [#13, #15, #16]

8b9318f

* Avoid mess-up of static/reusable vs. dynamic variables * Use stricter types where possible instead of "def" (watch out for fallout!) * Revise Set of Lists (as Tuples) vs. Maps for parallel stage preparation

Avoid NPEs and changing the original Map entries unexpectedly: use cl…

64301c3

…one()

DynamatrixStash.groovy: split() KEY=VALUE pairs into exactly 2 compon…

e29df00

…ents

Fix import/package markup (use ending semicolons consistently)

464205f

Fix dynacfg.compilerType / enum CompilerTypes use and comments

cbe307d

dynamatrixPipeline.groovy: fix dynacfgPipeline.notifyHandler() to use…

f1d7afe

… explicit .call() for compiler warnings

dynamatrixPipeline.groovy: Fix typo in exception var name

04977ae

Specify "package" in vars/*.groovy steps

4abe329

Clarify some code to address static analysis warnings

03496ed

Clarify some code to address static analysis warnings about equals()

57d5f15

Clarify some code to address static analysis warnings about ignored c…

0d36c6c

…atch()

Minor javadoc fixes

4bfb563

Dynamatrix.groovy: fix back comparisons of trackStageResults[] entrie…

ceaea80

…s and strings like ABORTED_SAFE

DynamatrixConfig: initDefault(): check and explicitly throw if dsbcSt…

337d41f

…ageTimeoutSettings is not a Map

DynamatrixConfig: introduce getDynamatrixAxesLabels() to manipulate a…

0d7088a

… Set normally

DynamatrixSingleBuildConfig.groovy: clarify stageNameFunc is a Closur…

7ace485

…e (also if it is a method reference)

DynamatrixStash: avoid fully-qualified class references

c16b942

Revert: Specify "package" in vars/*.groovy steps

78212bb

vars/withEnvOptional.groovy: fix back "env" which is not a Map but an…

56d16d4

… org.jenkinsci.plugins.workflow.cps.EnvActionImpl

Dynamatrix.groovy: avoid reporting "Build in progress: [:]" where we …

32e5c2b

…can do better

Dynamatrix.groovy: generateBuild(): when using a bodyOrig, pass same …

7eaab6f

…dsbc and stageName (static clone!) objects as in bodyData[] [#16]

Dynamatrix.groovy: generateBuild(): when using a bodyOrig, pass origi…

c58b081

…nal dsbc object, not a clone()

Dynamatrix.groovy: generateBuild(): when using a bodyOrig, dehydrate(…

3bd4347

…) the shared definition and rehydrate() to make a unique Closure instance Finally! Probably this is what fixes #16 (at least test runs do look better)

Dynamatrix.groovy: when tracing countStagesIncrement() report Dynamat…

323704c

…rix object identifier

Dynamatrix.groovy: generateBuild(): fix call to payloadTmp() and dsbc…

5052da4

…Result

dynamatrixPipeline.groovy: when tracing countStagesIncrement() report…

00a7c70

… Dynamatrix object identifier and avoid printing "Not all went well: [:]" if possible

Dynamatrix.groovy: constructor: report creation and caller

3b0abd6

Dynamatrix.groovy: "...in Dynamatrix instance" reporting update

bc11d00

jimklimov added 20 commits July 10, 2023 11:03

Introduce Dynamatrix.dynamatrixComment

49e270d

Use Dynamatrix.dynamatrixComment in debug printouts

996d70b

Use Dynamatrix.dynamatrixComment in new/clone calls

400288a

Use Dynamatrix.dynamatrixComment in new/clone calls with details of d…

6dcedde

…ynacfg*[] involved

Dynamatrix: countStagesIncrement(): change way of increments

e9569b7

Shorten the Dynamatrix.dynamatrixComment after new/clone calls to not…

e2ef7dc

… repeat details of dynacfg*[] involved

Dynamatrix: use ConcurrentHashMap to track results

547c366

Dynamatrix: use an explicit synchronised{} block to update countStages[]

e332972

vars/shellcheck.groovy: trace if calling prepareDynamatrix() step

e04e352

Dynamatrix.clone(): trace this.dynamatrixComment

ad46bc2

Dynamatrix.countStagesIncrement(): fix use of this.@countStages[] bec…

df0cac5

…ause a getter is also available

Optionally track Dynamatrix.knownClones and recurse into them for sta…

ce106fe

…ts (getWorstResult, verdict counters, etc.)

Dynamatrix: offload synchronized{} code of countStagesIncrement() int…

f7897d0

…o countStagesIncrementSync()

vars/shellcheck.groovy: no local var "debugTrace" yet

f39e642

Dynamatrix.groovy: constrain recently added debugs (constructor, clon…

12403af

…e, countStagesIncrement) with this.shouldDebugTrace()

Fix Dynamatrix.getWorstResult() to not consider child "null" verdicts…

8b46c47

… if recursing

Dynamatrix: avoid ConcurrentHashMap.clone()

78bb958

Dynamatrix: updateProgressBadge(): retry removal of older Badge just …

7df608f

…before publishing ours, to minimize dupes

Fix Dynamatrix.clone() to not multiply knownClones[]

ab669fc

Disable by default "remembering" and querying Dynamatrix.knownClones …

b7ba6c1

…(seems they have a way to store stats into parent after all)

jimklimov added bug Something isn't working enhancement New feature or request labels Jul 10, 2023

jimklimov mentioned this pull request Jul 10, 2023

Un-classified issue with Git checkout (should DynamatrixStash address this?) #19

Open

jimklimov merged commit ec3428d into master Jul 10, 2023

This was referenced Jul 10, 2023

CI: Dynamatrix issue 15 networkupstools/nut#1984

Merged

Fix reporting of quick-test phase failures and some fallout from #18 #22

Merged

jimklimov added a commit that referenced this pull request Jul 11, 2023

Merge pull request #22 from networkupstools/issue-21

0d3add3

Fix reporting of quick-test phase failures and some fallout from #18

jimklimov deleted the issue-15 branch July 11, 2023 17:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix issues #15 (double-accounting) and #16 (continued mix-up of DSBC goals and labels) #18

Fix issues #15 (double-accounting) and #16 (continued mix-up of DSBC goals and labels) #18

jimklimov commented Jul 10, 2023 •

edited

Loading

Fix issues #15 (double-accounting) and #16 (continued mix-up of DSBC goals and labels) #18

Fix issues #15 (double-accounting) and #16 (continued mix-up of DSBC goals and labels) #18

Conversation

jimklimov commented Jul 10, 2023 • edited Loading

jimklimov commented Jul 10, 2023 •

edited

Loading