Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bcmxcp_usb.c does not use nut_usb_addvars() #1764

Open
jimklimov opened this issue Jan 4, 2023 · 0 comments
Open

bcmxcp_usb.c does not use nut_usb_addvars() #1764

jimklimov opened this issue Jan 4, 2023 · 0 comments
Labels
MGE MGE branded devices and (USB) chipsets, now part of Eaton; mostly bcmxcp drivers USB
Milestone

Comments

@jimklimov
Copy link
Member

...and so lacks support for common USB-matching options like device, bus, serial.

A fix similar to that in #1763 was attempted but proved hard, at least in the way of moving upsdrv_makevartable() from common bcmxcp.c file to bcmxcp_ser.c and bcmxcp_usb.c, because this driver implements a fair amount of USB support privately and shares many symbols with libusbX.c files. This further complicates build/linking of nut-scanner as well.

Code from that attempt is parked at https://github.com/jimklimov/nut/tree/issue-1754-bcmxcp (jimklimov@9be75da)

No plan to address this soon, so keeping for posterity if someone does need to address it later and finds what I missed in the quick shot.

@jimklimov jimklimov added USB MGE MGE branded devices and (USB) chipsets, now part of Eaton; mostly bcmxcp drivers labels Jan 4, 2023
@jimklimov jimklimov added this to the 2.8.3 milestone Jan 15, 2023
jimklimov added a commit to efuss/nut that referenced this issue Jan 22, 2023
jimklimov added a commit to jimklimov/nut that referenced this issue Aug 10, 2024
…duct(id), and serial options for bcmxcp_usb, richcomm_usb, nutdrv_atcl_usb [networkupstools#1763, networkupstools#1764, networkupstools#1768, networkupstools#2580]

Signed-off-by: Jim Klimov <[email protected]>
jimklimov added a commit to jimklimov/nut that referenced this issue Aug 10, 2024
…duct(id), and serial options for bcmxcp_usb, richcomm_usb, nutdrv_atcl_usb [networkupstools#1763, networkupstools#1764, networkupstools#1768, networkupstools#2580]

Signed-off-by: Jim Klimov <[email protected]>
jimklimov added a commit to jimklimov/nut that referenced this issue Aug 10, 2024
…duct(id), and serial options for bcmxcp_usb, richcomm_usb, nutdrv_atcl_usb [networkupstools#1763, networkupstools#1764, networkupstools#1768, networkupstools#2580]

Signed-off-by: Jim Klimov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MGE MGE branded devices and (USB) chipsets, now part of Eaton; mostly bcmxcp drivers USB
Projects
None yet
Development

No branches or pull requests

1 participant