Refine ST_FLAG_NUMBER-related behaviours #357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ranges are now explicitly flagged as numbers, but the use of dstate_setflags() means that we substitute any previously-set flag with the ones we pass to that function, losing, for example, an already-set r/w status, with the result of making an affected var unchangeable. Use instead the newly added dstate_addflags() function, which preserves already-set flags.
|
I will admit that I have not been following this very closely, and I think that eventually we should have some test cases that exercise this code. But given the general lack of C unit-test infrastructure, don't let that stop you from merging. @aquette, any thoughts? |
|
@clepple fully agree with the need to improve tests in this area (was thinking the exact same yesterday). |
|
Thanks to all, rebased and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #265/#267:
ST_FLAG_NUMBERfor ranges throughdstate_setflags()causes the elimination of previously-set flags, inducing some side effects (e.g. if a var is first set as r/w and then its range is added -> the var loses its r/w status and becomes unchangeable): this PR introduces a support function to add flags (and its counterpart to remove flags) without losing the existing ones.ST_FLAG_NUMBER.