Fix php incompatibility

netz98 · Sep 7, 2023 · 7ce2c39 · 7ce2c39
1 parent c96a7d6
commit 7ce2c39
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/N98/Util/Unicode/Charset.php b/src/N98/Util/Unicode/Charset.php
@@ -27,10 +27,10 @@ class Charset
      * @param int|array $codes
      * @return string
      */
-    public static function convertInteger($codes)
+    public static function convertInteger(...$codes)
     {
-        if (is_scalar($codes)) {
-            $codes = func_get_args();
+        if (count($codes) === 1 && is_array($codes[0])) {
+            $codes = $codes[0];
         }
 
         $str = '';

diff --git a/tests/N98/Util/Unicode/CharsetTest.php b/tests/N98/Util/Unicode/CharsetTest.php
@@ -8,5 +8,13 @@ public function testConvertInteger()
     {
         $this->assertEquals('✖', Charset::convertInteger(Charset::UNICODE_CROSS_CHAR));
         $this->assertEquals('✔', Charset::convertInteger(Charset::UNICODE_CHECKMARK_CHAR));
+        $this->assertEquals(
+            '✔✖',
+            Charset::convertInteger(Charset::UNICODE_CHECKMARK_CHAR, Charset::UNICODE_CROSS_CHAR)
+        );
+        $this->assertEquals(
+            '✖✔',
+            Charset::convertInteger([Charset::UNICODE_CROSS_CHAR, Charset::UNICODE_CHECKMARK_CHAR])
+        );
     }
 }