Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update] layer prefix to be set at model level #1778

Merged
merged 16 commits into from
Oct 31, 2023

Commits on Oct 19, 2023

  1. - Update src/sparseml/modifiers/obcq/pytorch.py

    to use layer prefix for from model
    - Remove `layer_prefix` from `SparseGPTModifier` base
    - Update ModelMetaData to include layer_prefix
    - Added a convenience function to update missing
    values in RecipeMetaData instance from another RecipeMetaData instance
    - Update simplify recipe to also include metadata
    - Update simplify_combine_recipes to include metadata
    - Add layer_prefix property to `ModifiableModel`
    - propagate `layer_prefix` to superclass
    - update session.py to set_layer_prefix on the model
    before initializing modifiers
    - Update example recipe to include layer_prefix in metadata
    rahul-tuli committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    ce265a4 View commit details
    Browse the repository at this point in the history
  2. Add missing docstring

    rahul-tuli committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    9fa0374 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. - address review comment

    - update docstring
    - add test for `update_missing_metadata`
    rahul-tuli committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    046b85d View commit details
    Browse the repository at this point in the history
  2. Add test

    rahul-tuli committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    1bcf3a0 View commit details
    Browse the repository at this point in the history
  3. Style

    rahul-tuli committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    fe367d3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8206969 View commit details
    Browse the repository at this point in the history
  5. Fix tests

    rahul-tuli committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    c45c745 View commit details
    Browse the repository at this point in the history
  6. Style

    rahul-tuli committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    2c8f8a8 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Configuration menu
    Copy the full SHA
    19188fb View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. [modifier refactor] Add constant pruning tests (#1752)

    * Initial commit
    
    * Add end to end tests
    
    * Add e2e tests for constant pruning modifier
    
    * Move imports inside the test fuctions so
    that torch isn't imported unless running the tests
    
    * Update setup.py to not run modifier tests unless pytorch is specified
    
    * [Bugfix] .dict() method on Recipe (#1753)
    
    * Bugfix .dict() method on Recipe
    
    * Remove extraneous local test, [faulty commit]
    
    * [modifier refactor] Add serialization tests (#1755)
    
    * Add serialization tests
    
    * Clean up
    
    * Keep original stage and group names
    Clean up _get_yaml_dict
    
    * fix comment
    
    * Typo
    
    * [Unit Tests][Modifier Refactor] (#1756)
    
    * Move valid recipes to a helper file
    Add tests for session.py
    
    * Increase test coverage of src/sparseml/core/session.py
    to 100%
    Run Style
    Add logs to .gitignore
    
    * Increase coverage of tests/sparseml/core/test_state.py
    to 100%
    
    * add tests for lifecycle/event.py
    
    * Increase code coverage of lifecycle/event to
    100%
    
    * increase lifecycle/session.py code coverage to 93%
    
    * Address review comments from @Satrat
    
    * Address review comments on 1752 (#1772)
    
    Update makefile to only ignore *pytorch.py files in modifier dir
    Fix order in test
    Add regex to makefile
    Add helper function to determine if torch tests should be run
    Check masks
    Make transformers import optional in sparsegpt.py
    
    * Fix merge conflict
    
    * Add more tests to check valid modifiers are created (#1774)
    
    * [Bug][ConstantPruningModifier] Fix mask de register bug (#1773)
    
    * Fix mask de-register logic
    
    * forgot to remove commented out line
    
    * Move tests inside pytorch directory as requested
    
    * Fix session reset (#1790)
    rahul-tuli committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    04d05c4 View commit details
    Browse the repository at this point in the history
  2. fix datasets version to be compatible with fsspec (#1797)

    Sara Adkins authored and rahul-tuli committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    da27e82 View commit details
    Browse the repository at this point in the history
  3. Add kvcache config for Mistral (#1766)

    * Add kvcache config for Mistral
    
    * Update configs.py
    
    * Update configs.py
    mgoin authored and rahul-tuli committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    037e302 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    aaf80c3 View commit details
    Browse the repository at this point in the history
  5. Fix reset logic

    rahul-tuli committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    3b0b319 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Configuration menu
    Copy the full SHA
    8b7d859 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9734ef6 View commit details
    Browse the repository at this point in the history