Sparse Quantization Example Clarification #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 17, 2024 20:12
bfineran
previously approved these changes
Jun 17, 2024
added 2 commits
June 17, 2024 20:20
horheynm
approved these changes
Jun 17, 2024
dbarbuzzi
approved these changes
Jun 17, 2024
Satrat
pushed a commit
that referenced
this pull request
Jun 20, 2024
* clarify example * cleanup * update examples * update output name
Satrat
pushed a commit
that referenced
this pull request
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dbarbuzzi pointed out during QA testing that for the sparse quantized example it is not clear the code snippets are meant to be run one by one in the same Python instance. Updating the README to make this more explicit. Also updating the quantization config for w8a8 since "tensor" is the strategy we have been testing with for this example.