Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bte_with_cpd experiment tutorial notebook #389

Merged
merged 7 commits into from
Dec 11, 2020

Conversation

williamrxu
Copy link
Contributor

Reference issue

Closes Domain Adaptation with CPD Algorithm #379

Type of change

Documentation

What does this implement/fix?

Added tutorial notebook demonstrating the application of the CPD algorithm (https://arxiv.org/pdf/0905.2635.pdf) to improving backward transfer efficiency when given XOR and R-XOR tasks. Notebook: https://nbviewer.jupyter.org/github/williamrxu/ProgLearn/blob/staging/docs/tutorials/bte_with_cpd_exp.ipynb

Additional information

This is my Sprint 1 PR completing issue Domain Adaptation with CPD Algorithm #379.

@levinwil
Copy link
Collaborator

levinwil commented Dec 11, 2020

This looks great to me! Can you please add this to the web docs by adding a link to it here: https://github.com/neurodata/ProgLearn/blob/staging/docs/tutorials.rst

@PSSF23 Do you have any comments?

@PSSF23 PSSF23 linked an issue Dec 11, 2020 that may be closed by this pull request
Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levinwil I was going to mention the tutorial.rst but nothing more!

@williamrxu
Copy link
Contributor Author

@levinwil Added! I inserted it alphabetically. Please let me know if you want it to be last on the list or if I did not add it correctly.

@PSSF23
Copy link
Member

PSSF23 commented Dec 11, 2020

@williamrxu the order doesn't have to be very strict, but I believe everything must be after the installation guide.

So just move it one step below and everything good.

@PSSF23
Copy link
Member

PSSF23 commented Dec 11, 2020

@levinwil do you think the tutorial name is accurate? I think something like xor_rxor_cpd might be more relevant?

@levinwil
Copy link
Collaborator

@williamrxu I agree with @PSSF23. I think you should mentioned that it's on XOR/RXOR in the notebook filename. I also agree with @PSSF23 on the order of the notebooks: everything should be after the installation guide.

Rename experiment from bte_with_cpd to xor_rxor_with_cpd

Updated tutorials.rst
@williamrxu
Copy link
Contributor Author

williamrxu commented Dec 11, 2020

@levinwil @PSSF23 updated as requested.

  • Updated experiment name to xor_rxor_with_cpd
  • Moved experiment to last on the list on tutorials.rst

Co-Authored-By: sir-talksalott <[email protected]>
Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@williamrxu I corrected your tutorial name in the rst file, and everything should be good now.

@levinwil
Copy link
Collaborator

@PSSF23 i think this is ready to be merged into staging once it passes the tests. Do you agree?

@PSSF23
Copy link
Member

PSSF23 commented Dec 11, 2020

@levinwil yes.

@PSSF23 PSSF23 merged commit 000d3b8 into neurodata:staging Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Domain Adaptation with CPD Algorithm
3 participants