Pin pandas version for Py3.12 tests #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 14 14
Lines 854 854
=======================================
Hits 852 852
Misses 2 2 ☔ View full report in Codecov by Sentry. |
sfmig
changed the title
|
This looks like a pytables issue that's been fixed and merged into main, but their latest release 3.9.2 is dated Nov 2023 🤔 |
lochhh
changed the title
lochhh
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
Tests are failing because with Python 3.12, a
numpyinstall >=2.0.0 will conflict with the latestpandas.See here for more details.
What does this PR do?
Pins
pandasto < 2.2.2 if the Python version > 3.12 as a temporary fix.This results in an environment with
pandas=2.2.1andnumpy=1.26.4.Questions
References
The issue in numpy - although it seems that the problem should have been fixed in pandas 2.2.2
How has this PR been tested?
Tests pass locally and in CI.
Is this a breaking change?
No.
Does this PR require an update to the documentation?
No.
Checklist: