-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setup docs #264
Update setup docs #264
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 14 14
Lines 866 866
=======================================
Hits 864 864
Misses 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @lochhh for updating! yay for spotting the inconsistencies 🦅
Mostly minor comments on phrasing, which you can ofc take or leave. I had a go at using nested tabs, to retain the previous users/developers split, and also separated install and upgrade instructions. I like it, but feel free to edit or revert, it was mostly to see how it looked.
Re movement
vs movement: I will dump my current thoughts in PR #266. For this PR I think it makes sense to just make it consistent with itself. If we later decide to go monospace we will need to search / review everything anyways.
Thanks @sfmig for the suggestions! I agree that the update instructions seem hidden and love the idea of splitting install and update! Regarding the users/developers tabs, I'm thinking now, if we should just redirect developers to the contributing guide, as
If we go with the "redirect developers" method, should we have these in separate subheadings, rather than having a Developers tab which they click into, only to find that they need to click again (this is just my personal preference though 🤔). I also think it looks cleaner like this: I also changed the update instructions to recommend starting fresh instead, to prevent potential incompatibility issues - happy to revert if this is unnecessary. Lmk your thoughts! 😄 |
Quality Gate passedIssues Measures |
TLDR: I agree with everything 😁
Yes, good call! Much better for the reasons you say
Yes, it looks great! Feels more spacious ✨ 👩🚀 (and as you say less clicking, yay!)
Again good call, love the clarity! Thanks @lochhh, it's looking neat! 🚀 |
Description
What is this PR
Why is this PR needed?
This PR closes #254 and #262
What does this PR do?
This PR:
References
#254 #262
How has this PR been tested?
Installed movement from conda locally and ran
movement info
Docs built locally and on CI
Checklist: