Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove defaults from test_and_deploy.yml #275

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

sfmig
Copy link
Contributor

@sfmig sfmig commented Aug 19, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
We are currently using the defaults channel in our actions, which from Aug2024 is not free to use for our case

What does this PR do?
Add nodefaults channel to prevent from using the defaults channel. See docs

References

\

How has this PR been tested?

The CI in this PR shows the default channel is omitted.

Is this a breaking change?

No.

Does this PR require an update to the documentation?

Should we include this in our docs for our users?

Checklist:

  • [ n/a ] The code has been tested locally
  • [ n/a ] Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

sonarcloud bot commented Aug 19, 2024

@sfmig sfmig changed the title Update test_and_deploy.yml Remove defaults from test_and_deploy.yml Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.77%. Comparing base (abeaff1) to head (af3a910).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          14       14           
  Lines         883      883           
=======================================
  Hits          881      881           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@niksirbi niksirbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sfmig ! Looks good.

Should we include this in our docs for our users?

Do you mean in the installation instructions?
Probably not? I'd say it's not our job to tell everyone how to configure conda.

@adamltyson
Copy link
Member

Probably not? I'd say it's not our job to tell everyone how to configure conda.

I would say our job ends once we've pointed users in the right direction. I.e. we should recommend miniforge, but not miniconda. Other than that, it's up to them. Based on recent comments from Anaconda, I don't even know who can and can't use the default channels for free anymore anyway!

@niksirbi
Copy link
Member

Probably not? I'd say it's not our job to tell everyone how to configure conda.

I would say our job ends once we've pointed users in the right direction. I.e. we should recommend miniforge, but not miniconda. Other than that, it's up to them. Based on recent comments from Anaconda, I don't even know who can and can't use the default channels for free anymore anyway!

Our installation instructions begin by assuming people already have conda/mamba installed. Do you recommend mentioning to install conda via miniforge (in case they don't already have it installed)?

@adamltyson
Copy link
Member

Our installation instructions begin by assuming people already have conda/mamba installed. Do you recommend mentioning to install conda via miniforge (in case they don't already have it installed)?

I think that's fine. I think we should just recommend miniforge if we recommend a distribution.

@niksirbi niksirbi added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit 38246d9 Aug 22, 2024
17 checks passed
@sfmig sfmig deleted the smg/conda-nodefaults branch August 27, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants