-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove defaults
from test_and_deploy.yml
#275
Conversation
Add `nodefaults` channel to prevent from using the `defaults` channel. See [docs](https://docs.conda.io/projects/conda/en/4.6.1/user-guide/tasks/manage-environments.html#:~:text=You%20can%20exclude%20the%20default%20channels%20by%20adding%20nodefaults%20to%20the%20channels%20list.)
Quality Gate passedIssues Measures |
defaults
from test_and_deploy.yml
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
=======================================
Coverage 99.77% 99.77%
=======================================
Files 14 14
Lines 883 883
=======================================
Hits 881 881
Misses 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sfmig ! Looks good.
Should we include this in our docs for our users?
Do you mean in the installation instructions?
Probably not? I'd say it's not our job to tell everyone how to configure conda.
I would say our job ends once we've pointed users in the right direction. I.e. we should recommend miniforge, but not miniconda. Other than that, it's up to them. Based on recent comments from Anaconda, I don't even know who can and can't use the default channels for free anymore anyway! |
Our installation instructions begin by assuming people already have |
I think that's fine. I think we should just recommend miniforge if we recommend a distribution. |
Description
What is this PR
Why is this PR needed?
We are currently using the
defaults
channel in our actions, which from Aug2024 is not free to use for our caseWhat does this PR do?
Add
nodefaults
channel to prevent from using thedefaults
channel. See docsReferences
\
How has this PR been tested?
The CI in this PR shows the
default
channel is omitted.Is this a breaking change?
No.
Does this PR require an update to the documentation?
Should we include this in our docs for our users?
Checklist: