-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added new movement datasets figure, with caption #286
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
=======================================
Coverage 99.77% 99.77%
=======================================
Files 14 14
Lines 883 883
=======================================
Hits 881 881
Misses 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like it!
Just a suggestion on the caption but feel free to take/leave
```{figure} ../_static/dataset_structure.png | ||
:alt: movement dataset structure | ||
|
||
A schematic showing the structure of `poses` and `bboxes` datasets in `movement`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion for caption:
An xarray dataset is a collection of several data arrays that share some axes. The schematic shows the data arrays that make up the
poses
andbboxes
datasets inmovement
.
It is a bit more specific description, and I think the concept in the first sentence is worth hammering in. But I leave it up to you, it may be too lengthy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, I'll just say "dimensions" instead of "axes", to stay within xarray terminology.
Quality Gate passedIssues Measures |
Closes #250.
I updated the figure to show both
poses
andbboxes
datasets, as discussed. I also added a little caption. This is how it displays: