Investigate models failing nrntest run after CPP update

[alexsavulescu]

From #763:

b04feb12 35358
splitcell 97917
b08dec23 116830
b07dec27_20091025 106891
fdemo 138379 # don't worry about this one
b07dec17 105507
gap-modeldb 43039
nrntraub 82894
lytton98 7399
lytton97 9889
wang1996 26997
prknj 17664
b09jan08 116838
lytton99 7400

For reference:

Download those models and fix the nocmodl issues. If you do one, the others will likely fall into line.

The prknj differences are so small (1e-8) that they can be ignored.
The gap-modeldb differences aren't so small but the lines on the graphs overlap so I think it is acceptable. And i will diagnose the differences when I get time.
I think the fdemo differences are due to unique random seed on every run.
splitcell has empty gout because of rand.c compile errors, e.g.

rand.c:452:4: note: previous definition of ‘z’ was here
   (z)[0] = LOW(l); (z)[1] = HIGH(l); }
    ^

[alexsavulescu]

I've checked all models.

• new issues don't seem familiar to me at all (at least I don't recall seeing them while running nrnivmodl@cpp on ModelDBRepo, but after that came some CR commits and some merges). I get the feeling there must be a common root cause though.
• some of them fail even for nrnivmodl@master

I will continue investigating tomorrow.

[pramodk]

@alexsavulescu : ok, lets take a look together tomorrow.

[alexsavulescu]

Ok so I believe I got to the root of this. One change following the CR was interfering with the generated macros by adding one extra empty line \n. That lead to some crazy compile errors.. Will re-run models listed in this ticket to make sure there is no actual regression or anything else.

[alexsavulescu]

With fix dc62f2f nrn@master vs nrn@cpp behave consistently.

[alexsavulescu]

@nrnhines would it be easy to run again the tests for the aforementioned models? Otherwise I believe #763 is good for merge.

[nrnhines]

Will do so. Will know result in a couple hours.

[alexsavulescu]

Will do so. Will know result in a couple hours.

Great, thanks.

[nrnhines]

Still getting exactly the same problems with 8.0a-32-g4186296c . Do I have the right version?

[nrnhines]

Nevermind. I botched the test. Will try again.

[nrnhines]

All the "no such file or directory" issues are gone.

[pramodk]

🎉