Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make pytest-cov optional for -DNRN_ENABLE_TESTS #1250

Merged
merged 1 commit into from
May 5, 2021
Merged

make pytest-cov optional for -DNRN_ENABLE_TESTS #1250

merged 1 commit into from
May 5, 2021

Conversation

alexsavulescu
Copy link
Member

No description provided.

olupton
olupton approved these changes May 5, 2021
View reviewed changes
Copy link
Collaborator

@olupton olupton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small suggestion you can ignore if you want.

CMakeLists.txt Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2021 •
edited
Loading

Codecov Report

Merging #1250 (2b20699) into master (c8cb987) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1250      +/-   ##
==========================================
- Coverage   31.95%   31.83%   -0.13%     
==========================================
  Files         572      572              
  Lines      108988   108988              
==========================================
- Hits        34829    34696     -133     
- Misses      74159    74292     +133
Impacted Files Coverage Δ
share/lib/python/neuron/coreneuron.py 0.00% <0.00%> (-75.44%) ⬇️
src/parallel/bbssrvmpi.cpp 13.92% <0.00%> (-29.12%) ⬇️
src/parallel/bbsclimpi.cpp 29.87% <0.00%> (-20.13%) ⬇️
src/nrnmpi/bbsmpipack.cpp 74.01% <0.00%> (-12.43%) ⬇️
src/parallel/bbssrv2mpi.cpp 51.14% <0.00%> (-5.75%) ⬇️
src/parallel/bbs.cpp 62.91% <0.00%> (-1.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8cb987...2b20699. Read the comment docs.

@alexsavulescu alexsavulescu marked this pull request as draft May 5, 2021 07:47
@alexsavulescu alexsavulescu marked this pull request as ready for review May 5, 2021 08:18
olupton
olupton approved these changes May 5, 2021
View reviewed changes
Copy link
Collaborator

@olupton olupton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexsavulescu alexsavulescu merged commit 9560680 into master May 5, 2021
@alexsavulescu alexsavulescu deleted the pytestcov-optional branch May 5, 2021 10:08
@alexsavulescu alexsavulescu mentioned this pull request Jan 27, 2022
Merged
alexsavulescu added a commit that referenced this pull request Jan 28, 2022
@alexsavulescu
CMake: pytest-cov is now optional (#1250)
097e118
@alexsavulescu alexsavulescu mentioned this pull request Mar 22, 2022
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrnhines nrnhines nrnhines approved these changes

@olupton olupton olupton approved these changes

@pramodk pramodk Awaiting requested review from pramodk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexsavulescu @codecov-commenter @nrnhines @olupton