Add missing build dependency of hoc_module. #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing dependency of `hoc_module` on `rxd_cython_generated`. This declares that src/nrnpython/setup.py depends on generated .cpp files such as share/lib/python/neuron/rxd/geometry3d/graphicsPrimitives.cpp and fixes build errors.
pramodk
approved these changes
May 14, 2021
|
Was hitting this sometimes in local after switching to ninja. Makefile may have triggered it less often. |
Merged
alexsavulescu
pushed a commit
that referenced
this pull request
Jan 28, 2022
* Add missing dependency of `hoc_module` on `rxd_cython_generated` * This declares that src/nrnpython/setup.py depends on generated .cpp files such as share/lib/python/neuron/rxd/geometry3d/graphicsPrimitives.cpp and fixes build errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing dependency of
hoc_moduleonrxd_cython_generated.This declares that
src/nrnpython/setup.pydepends on generated .cpp files such asshare/lib/python/neuron/rxd/geometry3d/graphicsPrimitives.cppand fixes build errors such as https://github.com/neuronsimulator/nrn-build-ci/runs/2580705143?check_suite_focus=true:To reproduce the problem locally I had to reduce the number of parallel build jobs.
nrn-build-ciuses 2 jobs in Linux runners and 3 for macOS, and only Linux jobs were failing.