Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: fixes rxd.re_init so that it loads values from NEURON into rxd nodes. #1310

Merged
merged 4 commits into from
Jun 9, 2021

Conversation

adamjhn
Copy link
Member

@adamjhn adamjhn commented May 27, 2021

No description provided.

@adamjhn adamjhn added bug rxd reaction-diffusion labels May 27, 2021
@adamjhn adamjhn requested a review from ramcdougal May 27, 2021 16:34
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #1310 (2bba9a9) into master (60be8a2) will increase coverage by 0.10%.
The diff coverage is 96.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1310      +/-   ##
==========================================
+ Coverage   32.77%   32.87%   +0.10%     
==========================================
  Files         570      570              
  Lines      108847   108806      -41     
==========================================
+ Hits        35678    35774      +96     
+ Misses      73169    73032     -137     
Impacted Files Coverage Δ
share/lib/python/neuron/rxd/species.py 76.56% <95.83%> (+4.43%) ⬆️
share/lib/python/neuron/rxd/rxd.py 82.44% <100.00%> (+6.45%) ⬆️
share/lib/python/neuron/rxd/node.py 77.75% <0.00%> (+0.23%) ⬆️
src/nrnpython/rxd_extracellular.cpp 69.34% <0.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60be8a2...2bba9a9. Read the comment docs.

@ramcdougal ramcdougal merged commit 259e634 into neuronsimulator:master Jun 9, 2021
@ramcdougal ramcdougal deleted the rxd_reinit branch June 9, 2021 19:45
@alexsavulescu alexsavulescu mentioned this pull request Mar 22, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug rxd reaction-diffusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants