Refactor neuron.coreneuron for Python 3.10.x #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/neuronsimulator/nrn-build-ci/runs/4163851845 shows this fixes test execution on |
|
The |
alkino
reviewed
Nov 11, 2021
pramodk
approved these changes
Nov 11, 2021
|
Ignoring Windows CI as that's need to be handled separately anyway. |
Merged
alexsavulescu
pushed a commit
that referenced
this pull request
Jan 28, 2022
* Add getters/setters to neuron.coreneuron 'module'. * Collections.Callable is deprecated. * Code cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some Python 3.10.0 incompatibilities, as partly discussed in #1525.
The main changes are:
neuron.coreneuronto be a class instance with getter/setter methods, so that properties likecoreneuron.enableandcoreneuron.cell_permutealways have consistent values of consistent types. This stops us from relying on implicitfloat->intconversions in the Python C API, as described in NEURON build + tests do not pass on Fedora latest #1525.collections.abc.Callableinstead ofcollections.Callable, which is deprecated.test/coreneuron/test_datareturn.pycompare the twocoreneuron.cell_permutevalues that are valid givencoreneuron.gpu, instead of always trying to compare0and1.Closes #1525.
I tested this on BB5 + GPU (with Python 3.8) and on Fedora 35 in Docker. I still saw a couple of failures locally, but I think these are unrelated and that something is slightly broken in my macOS + Docker + Fedora 35 + MPI environment.