Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEURON can dynamically link to Python3.10 #1558

Merged
merged 2 commits into from
Dec 18, 2021
Merged

Conversation

nrnhines
Copy link
Member

The python3.10 relevant changes of #1524

It might be a good idea to add the code to make a python3.10 wheel installer.

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021

Codecov Report

Merging #1558 (486f5b7) into master (d3abfef) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1558      +/-   ##
==========================================
+ Coverage   43.79%   43.83%   +0.03%     
==========================================
  Files         552      552              
  Lines      110973   110974       +1     
==========================================
+ Hits        48602    48646      +44     
+ Misses      62371    62328      -43     
Impacted Files Coverage Δ
share/lib/python/neuron/__init__.py 32.40% <0.00%> (-0.05%) ⬇️
src/parallel/bbs.cpp 75.94% <0.00%> (+1.68%) ⬆️
src/parallel/bbssrvmpi.cpp 48.19% <0.00%> (+6.02%) ⬆️
src/parallel/bbsclimpi.cpp 58.13% <0.00%> (+8.13%) ⬆️
src/nrnmpi/bbsmpipack.cpp 93.33% <0.00%> (+10.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3abfef...486f5b7. Read the comment docs.

@alexsavulescu
Copy link
Member

It might be a good idea to add the code to make a python3.10 wheel installer.

yes there is a ticket for that, we can do it in a new PR (will take care of it on Monday). We may have to release NEURON 8.0.1.

@nrnhines nrnhines merged commit 530b310 into master Dec 18, 2021
@nrnhines nrnhines deleted the hines/nrnpython310 branch December 18, 2021 14:09
alexsavulescu added a commit that referenced this pull request Jan 28, 2022
@alexsavulescu alexsavulescu mentioned this pull request Mar 22, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants