Bug fix: wheel exe wrapper was not checking 'neuron' but only neuron-nightly* package
#1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`neuron-nightly*` package As part of #1452, we changed exe wrapper for GPU but introduced a bug where `neuron` package name was not checked
alexsavulescu
approved these changes
Mar 16, 2022
Codecov Report
@@ Coverage Diff @@
## master #1706 +/- ##
==========================================
+ Coverage 45.30% 45.34% +0.03%
==========================================
Files 551 551
Lines 111206 111206
==========================================
+ Hits 50380 50424 +44
+ Misses 60826 60782 -44
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #1452, we changed exe wrapper for GPU but
introduced a bug where
neuronpackage name was not checked